Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for UPI install on Power #3454

Merged
merged 1 commit into from Apr 20, 2020
Merged

Add instructions for UPI install on Power #3454

merged 1 commit into from Apr 20, 2020

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Apr 15, 2020 •
edited

@bpradipt
Copy link
Contributor Author

/assign @crawford

@manojnkumar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@crawford
Copy link
Contributor

/unassign

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@bpradipt bpradipt changed the title Add instructions for UPI install on PowerVM Add instructions for UPI install on Power Apr 15, 2020
patrickdillon
patrickdillon reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. I left some proofreading suggestions.

/lgtm

docs/user/power/install_upi.md Outdated Show resolved Hide resolved
docs/user/power/install_upi.md Show resolved Hide resolved
docs/user/power/install_upi.md Outdated Show resolved Hide resolved
docs/user/power/install_upi.md Outdated Show resolved Hide resolved
docs/user/power/install_upi.md Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@patrickdillon
Copy link
Contributor

/lgtm

1 similar comment
@manojnkumar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
ausil
ausil suggested changes Apr 16, 2020
View reviewed changes
Copy link

@ausil ausil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the content issues outlined

docs/user/power/install_upi.md Outdated Show resolved Hide resolved
docs/user/power/install_upi.md Show resolved Hide resolved
docs/user/power/install_upi.md Outdated Show resolved Hide resolved
docs/user/power/install_upi.md Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@bpradipt
Copy link
Contributor Author

Please address the content issues outlined

Have pushed the changes. Please review

@bpradipt
Copy link
Contributor Author

/retest

@manojnkumar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@bpradipt
Copy link
Contributor Author

/retest

@ausil
Copy link

ausil commented Apr 17, 2020

/lgtm

@ausil
Copy link

ausil commented Apr 17, 2020

/test e2e-aws-scaleup-rhel7

@manojnkumar
Copy link
Contributor

/lgtm

@bpradipt
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

1 similar comment
@bpradipt
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@manojnkumar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@manojnkumar
Copy link
Contributor

/test e2e-aws-scaleup-rhel7

@bpradipt
Copy link
Contributor Author

/assign abhinavdahiya

@bpradipt
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

wking
wking reviewed Apr 20, 2020
View reviewed changes
docs/user/power/install_upi.md
## Network Topology Requirements

The easiest way to get started is to ensure all Power nodes have internet access to pull images for platform containers and provide telemetry data to Red Hat.
OpenShift 4.x also supports air-gapped installs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: doc use "restricted network", because those sorts of issues happen in many situations, not all of which are actually air-gapped. And do we need to call this out at all? Saying "connected is easiest, but restricted-network is possible" without going into the details seems like an unnecessary straddle. Can we either drop this, or explain the restricted-network steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking the disconnected install doc is currently WIP. I'll add a link to it in a follow-on PR.

@crawford
Copy link
Contributor

@wking, I know you just added some comments, but due to some time constraints I'm going to go ahead and merge this now. @bpradipt, can you follow up with the suggestions in another PR?

/approve

@crawford crawford added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@bpradipt
Copy link
Contributor Author

@wking, I know you just added some comments, but due to some time constraints I'm going to go ahead and merge this now. @bpradipt, can you follow up with the suggestions in another PR?

/approve

yes sure.. thanks

@crawford
Copy link
Contributor

We aren't waiting on e2e tests for this update to the docs...

/override ci/prow/e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-aws-upgrade

In response to this:

We aren't waiting on e2e tests for this update to the docs...

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d7ed044 into openshift:master Apr 20, 2020
@manojnkumar manojnkumar mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@ausil ausil ausil requested changes

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@abhinavdahiya abhinavdahiya

@patrickdillon patrickdillon

@manojnkumar manojnkumar

@ausil ausil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bpradipt @manojnkumar @crawford @patrickdillon @ausil @openshift-ci-robot @wking @abhinavdahiya @openshift-merge-robot