Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile.upi.ci: Add GCP UPI required binaries. #3462

Merged
merged 2 commits into from Apr 21, 2020
Merged

Dockerfile.upi.ci: Add GCP UPI required binaries. #3462

merged 2 commits into from Apr 21, 2020

Conversation

jstuever
Copy link
Contributor

This change combines the two yum install calls in Dockerfile.upi.ci and adds the binaries used by CI to install a UPI GCP cluster.

@jstuever
Dockerfile.upi.ci: Combine yum install calls.
6571ce1 
This change combines the two yum install calls in the Dockerfile.upi.ci
image into a single one and moves it to after the yum upgrade call.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020
@jstuever jstuever force-pushed the cors1405 branch 2 times, most recently from a497df7 to 8bcaea9 Compare April 15, 2020 20:50
@jstuever jstuever mentioned this pull request Apr 15, 2020
Merged
@jstuever
Dockerfile.upi.ci: Add GCP UPI binaries to the CI Docker file.
47e5ce5 
This change adds the binaries used by CI to install a UPI GCP cluster.
@jstuever jstuever changed the title WIP: Dockerfile.upi.ci: Add GCP UPI binaries to the CI Docker file. WIP: Dockerfile.upi.ci: Add GCP UPI required binaries. Apr 15, 2020
@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi
/test e2e-aws-upi

@jstuever
Copy link
Contributor Author

/hold for e2e-asw-upi and e2e-gcp-upi

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@jstuever
Copy link
Contributor Author

/retest

4 similar comments
@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi

4 similar comments
@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi

@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi

@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi

@jstuever
Copy link
Contributor Author

/test e2e-gcp-upi

@jstuever jstuever changed the title WIP: Dockerfile.upi.ci: Add GCP UPI required binaries. Dockerfile.upi.ci: Add GCP UPI required binaries. Apr 20, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2020
@jstuever
Copy link
Contributor Author

/hold cancel
Both UPI tests succeeded.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2020
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya abhinavdahiya added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bc4e6d0 into openshift:master Apr 21, 2020
@jstuever
Copy link
Contributor Author

jstuever commented May 6, 2020

/cherry-pick release-4.4

@jstuever jstuever deleted the cors1405 branch May 6, 2020 15:08
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jstuever: new pull request created: #3559

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jstuever @patrickdillon @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot