installconfig/ovirt: fix CA prompt and add warning #3479
Conversation
This is a follow-on to 3eccc34. After looking at this more closely, I realized that the cert bundle is only prompted if the CA is trusted locally. This means that if the CA isn't trusted, the communication with the oVirt engine will be insecure. I added a warning to reflect that reality.
|
No need to wait for AWS e2e. /skip |
|
@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@crawford: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This is a follow-on to 3eccc34. After looking at this more closely, I
realized that the cert bundle is only prompted if the CA is trusted
locally. This means that if the CA isn't trusted, the communication with
the oVirt engine will be insecure. I added a warning to reflect that
reality.