Bug 1835867: data/data/aws/vpc: create subnet sizes based on az count #3599
Conversation
For every availabilty zone, we need a subnet. `ceil(log2(num of AZs))` finds the smallest exponent of 2 that is greater than or equal to `num of AZs` Using that to split the private/public machine_cidr range allows the installer to carve out network ranges for each AZ with minimum unused. Previously the installer would create 8 ranges always even when only a few were required.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
abhinavdahiya
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
abhinavdahiya
added
the
version/4.6
|
/test e2e-azure |
|
This is great! 🙌 |
abhinavdahiya
changed the title
abhinavdahiya
removed
the
version/4.6
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@abhinavdahiya: This pull request references Bugzilla bug 1835867, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/assign @patrickdillon @jstuever |
|
/retest |
|
/test e2e-aws |
|
for example the e2e-aws in this PR https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3599/pull-ci-openshift-installer-master-e2e-aws/11572 installs to 2 AZs
the subnets are created that completely covers the VPC, instead of previous it would only use some. |
|
/test e2e-aws-upgrade |
|
in comparison see the e2e-aws from a PR #3600 and job https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3600/pull-ci-openshift-installer-master-e2e-aws/11570 creating the same number of subnets but smaller.
|
This last sentence makes it sound like there is a change to the number of subnets carved out. That has changed the same, and it's the size of each subnet that has changed, right? |
subnet => AWS subnet resource and i tried to use these 2 terms separately to make that clear. and you are correct. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
23 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/installer#3599. Bugzilla bug 1835867 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@abhinavdahiya: new pull request created: #3614 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For every availability zone, we need a subnet.
ceil(log2(num of AZs))finds the smallest exponent of 2 that is greater than or equal tonum of AZsUsing that to split the private/public machine_cidr range allows the installer to carve out network ranges for each AZ with minimum unused.
Previously the installer would create 8 ranges always even when only a few were required.