Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1815071: check for api dns record before creating cluster #3601

Merged
merged 4 commits into from May 14, 2020
Merged

Bug 1815071: check for api dns record before creating cluster #3601

merged 4 commits into from May 14, 2020

Conversation

abhinavdahiya
Copy link
Contributor

For external clusters, we need to make sure there are no pre existing api.<cluster domain> dns records. To achieve that,
we find the public dns zone for the basedomain and list all the dns records. Checking for api.<cluster domain> in the retrieved
list shuold allow failing early.

/cc @jhixson74 @patrickdillon

@abhinavdahiya
pkg/asset/installconfig/gcp: update go generate for moc generation
cedd117 
update the destination of the generated mocks
@abhinavdahiya
pkg/asset/installconfig/gcp: add function to validate pre-existing ap…
311a2e9 
…i dns record

For external clusters, we need to make sure there are no pre existing `api.<cluster domain>` dns records. To achieve that,
we find the public dns zone for the basedomain and list all the dns records. Checking for `api.<cluster domain>` in the retrieved
list shuold allow failing early.
@abhinavdahiya
asset/installconfig/platformprovisioncheck.go: check for api dns reco…
ed69403 
…rd before creating cluster
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 14, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: This pull request references Bugzilla bug 1815071, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1815071: check for api dns record before creating cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

1 similar comment
@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 52586ea link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-ovirt 52586ea link /test e2e-ovirt
ci/prow/e2e-openstack 52586ea link /test e2e-openstack
ci/prow/e2e-libvirt 52586ea link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhixson74
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@abhinavdahiya
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 11bfe33 into openshift:master May 14, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/installer#3601. Bugzilla bug 1815071 has been moved to the MODIFIED state.

In response to this:

Bug 1815071: check for api dns record before creating cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 jhixson74 approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@jhixson74 jhixson74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhinavdahiya @openshift-ci-robot @jhixson74 @openshift-merge-robot