Bug 1838032: Don't create router to external network when BYO subnet is set #3632
Conversation
|
/cc @mandre |
|
/label platform/openstack |
iamemilio
force-pushed
the
byon_router_bugfix
branch
2 times, most recently
from
af9b34a
to
e48c2ed
Compare
|
/retitle Bug 1838032: Don't create router to external network when BYO subnet is set |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@iamemilio: This pull request references Bugzilla bug 1838032, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
iamemilio
force-pushed
the
byon_router_bugfix
branch
from
e48c2ed
to
1e836e1
Compare
|
/cc @morenod |
It may not be possible to set a router to the external network, or may not be necessary, depending on how the customer chooses to route their traffic. Since it is very hard to contextually deduce what external routing scheme the customer wants to set up, it is preferrable to just not attempt to automate anything for them, and let them customize it themselves.
iamemilio
force-pushed
the
byon_router_bugfix
branch
from
1e836e1
to
9859962
Compare
|
@iamemilio: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, morenod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@iamemilio: All pull requests linked via external trackers have merged: openshift/installer#3632. Bugzilla bug 1838032 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It may not be possible to set a router to the external network, or may
not be necessary, depending on how the customer chooses to route their traffic.
Since it is very hard to contextually deduce what external routing
scheme the customer wants to set up, it is preferrable to just not
attempt to automate anything for them, and let them customize it themselves.