Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1838631: Set validations for GCP disk sizes. #3639

Merged
merged 1 commit into from May 27, 2020
Merged

Bug 1838631: Set validations for GCP disk sizes. #3639

merged 1 commit into from May 27, 2020

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented May 21, 2020

Current disk size restrictions for GCP is set to be above 0.
The current size of the image is 16GB and hence the disk sizes
must at least be 16GB. Also, the maximum disk size limit on GCP
is 65536GB so users must not be allowed to create disks above that
limit. Added the validations to the install config input for GCP.

@rna-afk rna-afk changed the title GCP: Set validations for GCP disk sizes. Bug 1838631: Set validations for GCP disk sizes. May 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 21, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1838631, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1838631: Set validations for GCP disk sizes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 21, 2020
@rna-afk
Copy link
Contributor Author

rna-afk commented May 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 21, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1838631, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 21, 2020
@abhinavdahiya
Copy link
Contributor

needs a bump in docs.

@rna-afk rna-afk force-pushed the gcp-disk-size-validations branch from 5d639aa to 6a1e948 Compare May 21, 2020 18:10
@abhinavdahiya
Copy link
Contributor

/test e2e-gcp

@patrickdillon
Copy link
Contributor

needs a bump in docs.

Probably want to update this as well:
https://github.com/openshift/installer/blob/master/docs/user/gcp/customization.md#machine-pools

I'm not sure if updating repo docs is sufficient or whether we need to also update official docs as well.

Otherwise LGTM.

@rna-afk
GCP: Set validations for GCP disk sizes.
206fdc7 
Current disk size restrictions for GCP is set to be above 0.
The current size of the image is 16GB and hence the disk sizes
must at least be 16GB. Also, the maximum disk size limit on GCP
is 65536GB so users must not be allowed to create disks above that
limit. Added the validations to the install config input for GCP.
@rna-afk rna-afk force-pushed the gcp-disk-size-validations branch from 6a1e948 to 206fdc7 Compare May 26, 2020 17:29
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@rna-afk
Copy link
Contributor Author

rna-afk commented May 26, 2020

/test e2e-aws-upgrade

@rna-afk
Copy link
Contributor Author

rna-afk commented May 26, 2020

/test e2e-gcp
/test images

@rna-afk
Copy link
Contributor Author

rna-afk commented May 26, 2020

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 690817b into openshift:master May 27, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: All pull requests linked via external trackers have merged: openshift/installer#3639. Bugzilla bug 1838631 has been moved to the MODIFIED state.

In response to this:

Bug 1838631: Set validations for GCP disk sizes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rna-afk @openshift-ci-robot @abhinavdahiya @patrickdillon @openshift-bot @openshift-merge-robot