Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Add numbers to disk requirements #3669

Merged

Conversation

pierreprinetti
Copy link
Member

Before this documentation change, there was no clear indication of the
expected disk latency in the OpenStack requirements.

The threshold value (10ms) is taken from a post1 on the IBM Cloud blog,
which the official ETCD documentation points to.

/label platform/openstack

Before this documentation change, there was no clear indication of the
expected disk latency in the OpenStack requirements.

The threshold value (10ms) is taken from a post[1] on the IBM Cloud blog,
which the official ETCD documentation points to.

[1]: https://www.ibm.com/cloud/blog/using-fio-to-tell-whether-your-storage-is-fast-enough-for-etcd
@pierreprinetti
Copy link
Member Author

/test e2e-aws-upgrade gofmt golint govet images shellcheck tf-lint unit verify-vendor yaml-lint

@mandre
Copy link
Member

mandre commented May 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@pierreprinetti
Copy link
Member Author

/test images shellcheck tf-lint yaml-lint

@pierreprinetti
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@pierreprinetti
Copy link
Member Author

/test shellcheck tf-lint yaml-lint

@pierreprinetti
Copy link
Member Author

/test tf-lint yaml-lint

@pierreprinetti
Copy link
Member Author

/test yaml-lint

@openshift-merge-robot openshift-merge-robot merged commit 4768827 into openshift:master Jun 1, 2020
@pierreprinetti pierreprinetti deleted the os_disk_reqs_explicit branch June 2, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants