Fix re-generation of install config on wait-for install-complete command #3681
Conversation
rna-afk
requested review from
abhinavdahiya
and removed request for
patrickdillon and
jstuever
|
Seems like a rather peculiar case. I tried to test it by removing the install config and the openshift_install_state.json but let me know if there are any other ways to test it. |
rna-afk
force-pushed
the
waitfor-install-complete-platform-fix
branch
from
3c0c9be
to
8846ff7
Compare
cmd/openshift-install/create.go
Outdated
| timeout := 30 * time.Minute | ||
| timeout := 60 * time.Minute | ||
|
|
||
| // Wait longer for baremetal, due to length of time it takes to boot | ||
| if assetStore, err := assetstore.NewStore(rootOpts.dir); err == nil { | ||
| installConfig := &installconfig.InstallConfig{} | ||
| if err := assetStore.Fetch(installConfig); err == nil { | ||
| if installConfig.Config.Platform.Name() == baremetal.Name { | ||
| timeout = 60 * time.Minute | ||
| if installConfig, err := assetStore.Load(&installconfig.InstallConfig{}); err == nil && installConfig != nil { | ||
| if installConfig.(*installconfig.InstallConfig).Config.Platform.Name() != baremetal.Name { | ||
| timeout = 30 * time.Minute |
There was a problem hiding this comment.
i think we need to do the reverse, default 30, if found as baremetal switch to 60...
If the cluster is created and the wait-for install-complete command is called to check the status, the installer checks if the install config exists to get the platform information to set the timeout for baremetal clusters a little higher. Since the install config is consumed during the cluster creation, the installer will then start to re-generate the install config and ask the user to provide the information again. Modified the platform information gathering to only pick the information up only if the information is available and if it does not exist, set the timeout value to the maximum value required as default. This will now avoid re-generation of the install config.
rna-afk
force-pushed
the
waitfor-install-complete-platform-fix
branch
from
8846ff7
to
54bf1a1
Compare
|
/fixes #3678 |
|
/approve |
|
/test e2e-metal-ipi |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-metal |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
18 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rna-afk: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
If the cluster is created and the wait-for install-complete command
is called to check the status, the installer checks if the install
config exists to get the platform information to set the timeout for
baremetal clusters a little higher. Since the install config is
consumed during the cluster creation, the installer will then start
to re-generate the install config and ask the user to provide the
information again.
Modified the platform information gathering to only pick the information
up only if the information is available and if it does not exist, set the
timeout value to the maximum value required as default (60 seconds
as the baremetal machines take long time to boot). This will now
avoid re-generation of the install config.