Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPI on OSP] make remove network and port more faster #3696

Merged
merged 1 commit into from Jun 8, 2020
Merged

[UPI on OSP] make remove network and port more faster #3696

merged 1 commit into from Jun 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2020

No description provided.

@ghost
Copy link
Author

ghost commented Jun 1, 2020

@MaysaMacedo @pierreprinetti help review this, Thanks

@MaysaMacedo
Copy link
Contributor

Thanks for contributing @wjiangjay. Could you add a commit message explaining how the new changes make it faster?

@MaysaMacedo
Copy link
Contributor

/label platform/openstack

@ghost
Copy link
Author

ghost commented Jun 1, 2020

@MaysaMacedo Thanks for checking, and I update the commit message to

    [UPI on OSP] make remove network and port more faster

    Merge ports deletion requests to one instead of deleting one by one to save time.
    And also for networks

Merge ports deletion requests to one instead of deleting one by one to save time.
And also for networks
@ghost
Copy link
Author

ghost commented Jun 2, 2020

/retest

@pierreprinetti
Copy link
Member

/approve
Thanks!
I am not sure if there's a lot of gain for networks though.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@ghost
Copy link
Author

ghost commented Jun 6, 2020

@pierreprinetti yes, before this, the deletion will cost about 45~60 minutes.
With this, it will be 20 ~ 30 minutes.

@MaysaMacedo
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@wjiangjay: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt b97603c link /test e2e-ovirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b2117cb into openshift:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants