Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.5] Bug 1844709: allow OpaqueNetwork type in vSphere wizard #3727

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3718

/assign patrickdillon

The vSphere wizard only allows users to select networks of certain
types. This commit adds the ability to select OpaqueNetworks.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1844103 has been cloned as Bugzilla bug 1844709. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1844709: allow OpaqueNetwork type in vSphere wizard

In response to this:

[release-4.5] Bug 1844103: allow OpaqueNetwork type in vSphere wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1844103: allow OpaqueNetwork type in vSphere wizard [release-4.5] Bug 1844709: allow OpaqueNetwork type in vSphere wizard Jun 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 6, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1844709, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1844103 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1844103 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1844709: allow OpaqueNetwork type in vSphere wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 6, 2020
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2020
@sdodson
Copy link
Member

sdodson commented Jun 8, 2020

/approve

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jun 8, 2020

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-disruptive, ci/prow/e2e-azure-upi, ci/prow/e2e-gcp, ci/prow/e2e-gcp-upi, ci/prow/e2e-metal-ipi, ci/prow/e2e-openstack

In response to this:

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jun 9, 2020

/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-aws-disruptive

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-disruptive, ci/prow/e2e-azure-upi, ci/prow/e2e-gcp-upi

In response to this:

/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-aws-disruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jun 9, 2020

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-disruptive, ci/prow/e2e-azure-upi, ci/prow/e2e-gcp, ci/prow/e2e-gcp-upi, ci/prow/e2e-metal-ipi, ci/prow/e2e-openstack

In response to this:

/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jun 9, 2020

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws-upi
/override ci/prow/e2e-azure
/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-scaleup-rhel7, ci/prow/e2e-aws-upgrade, ci/prow/e2e-aws-upi, ci/prow/e2e-azure, ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws-upi
/override ci/prow/e2e-azure
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ac35366 into openshift:release-4.5 Jun 9, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/installer#3727. Bugzilla bug 1844709 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1844709: allow OpaqueNetwork type in vSphere wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants