Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.5] Bug 1846297: OpenStack: Wait for router interface to create FIP #3740

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3734

/assign mandre

The api_fip should have an explicit dependency on the
nodes_router_interface otherwise it may fail with:

  Error: Error associating openstack_networking_floatingip_associate_v2 floating_ip xxx with port xxx: Resource not found
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1734460 has been cloned as Bugzilla bug 1846297. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1846297: OpenStack: Wait for router interface to create FIP

In response to this:

[release-4.5] Bug 1734460: OpenStack: Wait for router interface to create FIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1734460: OpenStack: Wait for router interface to create FIP [release-4.5] Bug 1846297: OpenStack: Wait for router interface to create FIP Jun 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1846297, which is invalid:

  • expected dependent Bugzilla bug 1734460 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1846297: OpenStack: Wait for router interface to create FIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morenod
Copy link
Contributor

morenod commented Jun 11, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

@morenod: This pull request references Bugzilla bug 1846297, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1734460 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1734460 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 11, 2020
@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/hold for e2e-openstack

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2020
@pierreprinetti
Copy link
Member

/test e2e-aws-disruptive e2e-azure-upi e2e-gcp-upi e2e-vsphere

@sdodson
Copy link
Member

sdodson commented Jun 12, 2020

/retest

2 similar comments
@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link
Author

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 16, 2020
@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

/test e2e-openstack

@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

/approve
/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-vsphere

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-disruptive, ci/prow/e2e-azure-upi, ci/prow/e2e-gcp-upi, ci/prow/e2e-vsphere

In response to this:

/approve
/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-azure-upi
/override ci/prow/e2e-gcp-upi
/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

@pierreprinetti looks like e2e-openstack has passed, clear the hold?

@pierreprinetti
Copy link
Member

/hold cancel

@\sdodson Oh yes!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member

/retest
@sdodson Any chance we can benefit again from your override superpowers? QE is getting nervous

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jun 17, 2020

/override ci/prow/e2e-vsphere-upi
/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-gcp
/override ci/prow/e2e-vsphere
/override ci/prow/e2e-gcp-upi

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-disruptive, ci/prow/e2e-gcp, ci/prow/e2e-gcp-upi, ci/prow/e2e-vsphere, ci/prow/e2e-vsphere-upi

In response to this:

/override ci/prow/e2e-vsphere-upi
/override ci/prow/e2e-aws-disruptive
/override ci/prow/e2e-gcp
/override ci/prow/e2e-vsphere
/override ci/prow/e2e-gcp-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2874fb3 into openshift:release-4.5 Jun 17, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/installer#3740. Bugzilla bug 1846297 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1846297: OpenStack: Wait for router interface to create FIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@pierreprinetti: new pull request created: #3764

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants