Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1878758: openstack UPI: Optional floating IPs #3755

Merged
merged 1 commit into from Sep 14, 2020
Merged

Bug 1878758: openstack UPI: Optional floating IPs #3755

merged 1 commit into from Sep 14, 2020

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jun 15, 2020 •
edited

Add the option to disable the use of floating IPs

/assign adduarte iamemilio

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2020
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pierreprinetti
Copy link
Member Author

/test e2e-openstack-upi

@iamemilio
Copy link

This seems reasonable

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest
oh cmon Prow, we are entirely able to mess up by ourselves without your help

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@iamemilio
Copy link

sorry about the review delay, but lgtm

@pierreprinetti
Copy link
Member Author

Note for self:
Change os_use_fip to like bootstrap_fip. The other two can probably be set conditionally if the ip is not empty?

@pierreprinetti pierreprinetti marked this pull request as ready for review July 21, 2020 20:59
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2020
iamemilio
iamemilio reviewed Jul 21, 2020
View reviewed changes
Copy link

@iamemilio iamemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this is may be confusing for users, or if it doesn't matter

upi/openstack/inventory.yaml Show resolved Hide resolved
@adduarte
Copy link

to align with IPI you should based it on weather or not external network and lbFloatingIP is defined, and also not create a router if no external network.

@pierreprinetti pierreprinetti force-pushed the os_upi_fipless branch 3 times, most recently from b26dd12 to 253d04e Compare July 22, 2020 14:36
@pierreprinetti
Copy link
Member Author

/retest

@iamemilio
Copy link

/test e2e-openstack-upi

@pierreprinetti
Copy link
Member Author

/test e2e-openstack-parallel

@pierreprinetti
Copy link
Member Author

/retest

1 similar comment
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

Needs openshift/release#11785

@pierreprinetti
Copy link
Member Author

/test e2e-openstack-upi

@pierreprinetti
Copy link
Member Author

/retitle Bug 1878758: openstack UPI: Optional floating IPs

@openshift-ci-robot openshift-ci-robot changed the title openstack UPI: Optional floating IPs Bug 1878758: openstack UPI: Optional floating IPs Sep 14, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1878758, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878758: openstack UPI: Optional floating IPs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

/hold cancel
CI passed!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2020
mandre
mandre approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2020 •
edited

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-parallel 5b45386 link /test e2e-openstack-parallel
ci/prow/e2e-crc 5b45386 link /test e2e-crc
ci/prow/e2e-libvirt 5b45386 link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 310d539 into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1878758 has been moved to the MODIFIED state.

In response to this:

Bug 1878758: openstack UPI: Optional floating IPs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the os_upi_fipless branch September 15, 2020 07:09
@pierreprinetti pierreprinetti restored the os_upi_fipless branch September 25, 2020 15:46
@pierreprinetti pierreprinetti deleted the os_upi_fipless branch September 25, 2020 15:47
This was referenced Sep 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@luis5tb luis5tb Awaiting requested review from luis5tb

@adduarte adduarte Awaiting requested review from adduarte

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees

@mandre mandre

@iamemilio iamemilio

@adduarte adduarte

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @openshift-ci-robot @iamemilio @adduarte @mandre @openshift-bot @openshift-merge-robot