gcp: Fix uninstaller for internal clusters on GCP. #3770
Conversation
Fixed the GCP uninstaller to get the instance group self links which would be used to destroy them. Currently, the self links are used but are not requested from GCP as a field when the instance groups are listed. Therefore, the uninstaller does not get the appropriate link to target for deletion.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-gcp |
|
/test images |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixed the GCP uninstaller to get the instance group self links which
would be used to destroy them. Currently, the self links are used but
are not requested from GCP as a field when the instance groups are listed.
Therefore, the uninstaller does not get the appropriate link to target
for deletion. This fix is for the internal clusters uninstallation.