Bug 1858683: data/data/bootstrap: prepend DNS VIP via NM script instead of dhclient #3777
Conversation
|
/test e2e-vsphere |
|
/cherry-pick release-4.5 |
|
@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,22 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
how is this handled in the control-plane? Using a bash script like this or something else?
There was a problem hiding this comment.
MCO installs a more sophisticated prepender - https://github.com/openshift/machine-config-operator/blob/master/templates/master/00-master/vsphere/files/NetworkManager-resolv-prepender.yaml, but its using the same idea
/retest |
|
machine-api reconciler is crashing - https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/3777/pull-ci-openshift-installer-master-e2e-vsphere/1274041407627071488/artifacts/e2e-vsphere/gather-extra/pods/openshift-machine-api_machine-api-controllers-589f4b8fd5-wx54q_machine-controller.log The change affects the bootstrap node only though /retest |
|
/retest |
|
Looks like the VMWare issue is a legit issue. Probably flakes through sometimes depending on how fast the vmware cluster creates tasks. |
vrutkovs
force-pushed
the
vsphere-no-dhclient
branch
from
1d1c17f
to
cc700b4
Compare
|
/test e2e-vsphere |
vrutkovs
changed the title
|
lgtm ovirt |
| @@ -1,2 +1 @@ | |||
| send dhcp-client-identifier = hardware; | |||
There was a problem hiding this comment.
Not entirely sure what's the NM equivalent of this
There was a problem hiding this comment.
vrutkovs
force-pushed
the
vsphere-no-dhclient
branch
from
cc700b4
to
ada9049
Compare
|
/test e2e-vsphere |
|
/retest |
1 similar comment
|
/retest |
… dhclient `dhclient` is not available in FCOS and removed in RHCOS 4.6. This would ensure local resolver is used by bootstrap service when it attempts to reach to API via `api-int` endpoint.
vrutkovs
force-pushed
the
vsphere-no-dhclient
branch
from
ada9049
to
f5890ea
Compare
|
/test e2e-vsphere |
1 similar comment
|
/test e2e-vsphere |
/retest |
|
/test e2e-vsphere |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-vsphere |
|
Workers are coming up. I think this is far enough into the process to determine if this resolves the issue. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@vrutkovs: new pull request created: #3937 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
abhinavdahiya
changed the title
|
@vrutkovs: All pull requests linked via external trackers have merged: . Bugzilla bug 1858683 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dhclientis not available in FCOS and removed in RHCOS 4.6. This wouldensure local resolver is used by bootstrap service when it attempts
to reach to API via
api-intendpoint.