Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack: Deleting servers using tag-based filtering #3818

Merged
merged 1 commit into from Jul 16, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jun 29, 2020

Now to delete servers we first get a list of all available servers from Nova, and then we iterate through them to find those with required metadata. In the case of a large number of servers, this can take a very long time.

Fortunately gophercloud introduced filtering by tags, so we can start using this feature to get only servers with the required tag.
gophercloud/gophercloud#1759

@mandre
Copy link
Member

mandre commented Jun 30, 2020

To save others the trouble to look it up, this was introduced in gophercloud v0.7.0, and we're using v0.8.0.

/approve
/lgtm
/hold until CI passes

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@pierreprinetti
Copy link
Member

/retest

Now to delete servers we first get a list of all available servers
from Nova, and then we iterate through them to find those with
required metadata. In the case of a large number of servers, this
can take a very long time.

Fortunately gophercloud introduced filtering by tags, so we can
start using this feature to get only servers with the required tag.
gophercloud/gophercloud#1759
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@mandre
Copy link
Member

mandre commented Jul 10, 2020

/recheck

@mandre
Copy link
Member

mandre commented Jul 10, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jul 14, 2020

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Jul 15, 2020

/lgtm

@mandre
Copy link
Member

mandre commented Jul 15, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9944c1a into openshift:master Jul 16, 2020
Fedosin added a commit to Fedosin/installer that referenced this pull request Aug 10, 2020
In openshift#3818 we introduced
tag-based server delition. Unfortunately it turned out we can destroy
servers, created by previous versions, as no tags were set there.

To fix this situation we come back to the previous solution - deleting
servers by metadata.
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Aug 20, 2020
In openshift#3818 we introduced
tag-based server delition. Unfortunately it turned out we can destroy
servers, created by previous versions, as no tags were set there.

To fix this situation we come back to the previous solution - deleting
servers by metadata.
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Aug 29, 2020
In openshift#3818 we introduced
tag-based server delition. Unfortunately it turned out we can destroy
servers, created by previous versions, as no tags were set there.

To fix this situation we come back to the previous solution - deleting
servers by metadata.
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Aug 31, 2020
In openshift#3818 we introduced
tag-based server delition. Unfortunately it turned out we can destroy
servers, created by previous versions, as no tags were set there.

To fix this situation we come back to the previous solution - deleting
servers by metadata.
vrutkovs pushed a commit to vrutkovs/installer that referenced this pull request Sep 2, 2020
In openshift#3818 we introduced
tag-based server delition. Unfortunately it turned out we can destroy
servers, created by previous versions, as no tags were set there.

To fix this situation we come back to the previous solution - deleting
servers by metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants