Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upi/vsphere: Make cidr_to_ip.sh more verbose #3821

Merged
merged 1 commit into from Jul 1, 2020
Merged

upi/vsphere: Make cidr_to_ip.sh more verbose #3821

merged 1 commit into from Jul 1, 2020

Conversation

LorbusChris
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2020
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

patrickdillon
patrickdillon reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
left nitpicky suggestion
cc @jcpowermac

upi/vsphere/ipam/cidr_to_ip.sh Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@LorbusChris LorbusChris changed the title DNM: Debug: upi/vsphere: Make cidr_to_ip.sh more verbose upi/vsphere: Make cidr_to_ip.sh more verbose Jul 1, 2020
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@jcpowermac
Copy link
Contributor

Cleaned up IPAM. Let's make sure first that UPI completes install then I will approve

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt f5afcdd link /test e2e-ovirt
ci/prow/e2e-openstack f5afcdd link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 f5afcdd link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-vsphere-upi f5afcdd link /test e2e-vsphere-upi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@jcpowermac
Copy link
Contributor

@LorbusChris terraform and the script worked as expected something else is wrong with master.
/lgtm

@jcpowermac
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 57ddc04 into openshift:master Jul 1, 2020
@runcom runcom mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@patrickdillon patrickdillon

@jcpowermac jcpowermac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LorbusChris @patrickdillon @jcpowermac @openshift-ci-robot @openshift-merge-robot