Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1864677: bootkube.sh: update cluster-config-operator to generate bootstrap configmap #3831

Merged
merged 1 commit into from Aug 4, 2020
Merged

Bug 1864677: bootkube.sh: update cluster-config-operator to generate bootstrap configmap #3831

merged 1 commit into from Aug 4, 2020

Conversation

jhixson74
Copy link
Member

This updates bootkube.sh to have the cluster-config-operator to generate a configmap from an infrastructure and cloud config file.

https://issues.redhat.com/browse/CORS-1458

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 2, 2020 •
edited

/lgtm

although I guess this depends on openshift/cluster-config-operator#140
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2020
@jhixson74 jhixson74 changed the title bootkube.sh: update cluster-config-operator to generate bootstrap configmap [WIP] bootkube.sh: update cluster-config-operator to generate bootstrap configmap Jul 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2020
@jhixson74 jhixson74 force-pushed the master_cluster_config_operator_bootstrap branch from d32d53a to c3b0059 Compare July 6, 2020 18:01
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@abhinavdahiya
Copy link
Contributor

/retest

@abhinavdahiya
Copy link
Contributor

/test e2e-gcp
/test e2e-vsphere
/test e2e-metal-ipi

@abhinavdahiya
Copy link
Contributor

/test e2e-vsphere-upi

@abhinavdahiya
Copy link
Contributor

openshift/cluster-config-operator#140 has merged so we can remove the hold

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@jhixson74 jhixson74 changed the title [WIP] bootkube.sh: update cluster-config-operator to generate bootstrap configmap bootkube.sh: update cluster-config-operator to generate bootstrap configmap Jul 28, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2020
@jhixson74
Copy link
Member Author

/retest

3 similar comments
@jhixson74
Copy link
Member Author

/retest

@jhixson74
Copy link
Member Author

/retest

@jhixson74
Copy link
Member Author

/retest

@jhixson74 jhixson74 force-pushed the master_cluster_config_operator_bootstrap branch from c3b0059 to 4b9c159 Compare July 30, 2020 19:48
@jhixson74
Copy link
Member Author

/test e2e-azure

@jhixson74
Copy link
Member Author

/retest

1 similar comment
@jhixson74
Copy link
Member Author

/retest

@abhinavdahiya
Copy link
Contributor

/test e2e-gcp

@abhinavdahiya abhinavdahiya changed the title bootkube.sh: update cluster-config-operator to generate bootstrap configmap Bug 1864677: bootkube.sh: update cluster-config-operator to generate bootstrap configmap Aug 3, 2020
@abhinavdahiya
Copy link
Contributor

We need openshift/machine-config-operator#1973 to accept the new generated config map

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 3, 2020
@openshift-ci-robot
Copy link
Contributor

@jhixson74: This pull request references Bugzilla bug 1864677, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1864677: bootkube.sh: update cluster-config-operator to generate bootstrap configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 3, 2020
@jhixson74 jhixson74 force-pushed the master_cluster_config_operator_bootstrap branch from 3c0b9bc to b132ea8 Compare August 3, 2020 21:18
@sdodson
Copy link
Member

sdodson commented Aug 4, 2020

/retest

@sdodson
Copy link
Member

sdodson commented Aug 4, 2020

/test e2e-azure

1 similar comment
@jhixson74
Copy link
Member Author

/test e2e-azure

@abhinavdahiya
Copy link
Contributor

/test e2e-gcp
/test e2e-vsphere

@jhixson74
Copy link
Member Author

Can we force a different region or bump the quota so this will pass?

@sdodson
Copy link
Member

sdodson commented Aug 4, 2020

/test e2e-azure

@brenton
Copy link
Contributor

brenton commented Aug 4, 2020 •
edited

Are we hitting flakes / quota limits with the failed jobs?

@abhinavdahiya
Copy link
Contributor

/test e2e-azure

1 similar comment
@jhixson74
Copy link
Member Author

/test e2e-azure

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

@abhinavdahiya
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 4, 2020 •
edited

@jhixson74: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-upi c3b0059 link /test e2e-vsphere-upi
ci/prow/e2e-openstack b132ea8 link /test e2e-openstack
ci/prow/e2e-vsphere b132ea8 link /test e2e-vsphere
ci/prow/e2e-ovirt b132ea8 link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cc5eeaa into openshift:master Aug 4, 2020
@openshift-ci-robot
Copy link
Contributor

@jhixson74: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1973, openshift/installer#3831. Bugzilla bug 1864677 has been moved to the MODIFIED state.

In response to this:

Bug 1864677: bootkube.sh: update cluster-config-operator to generate bootstrap configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@abhinavdahiya abhinavdahiya

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jhixson74 @patrickdillon @abhinavdahiya @sdodson @openshift-ci-robot @brenton @openshift-bot @openshift-merge-robot