Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1813354: OpenStack: Fix the cacert trustbundle parser #3840

Merged
merged 1 commit into from Jul 9, 2020
Merged

Bug 1813354: OpenStack: Fix the cacert trustbundle parser #3840

merged 1 commit into from Jul 9, 2020
+361 −24

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jul 3, 2020 •
edited

Fix a bug where a trailing empty line caused an error.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 3, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1813354, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1813354: OpenStack: Trim EOLs from the cacert trustbundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jul 3, 2020

/approve
/lgtm
/hold until e2e-openstack passes

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020
@pierreprinetti
Copy link
Member Author

/retest

@abhinavdahiya
Copy link
Contributor

Hmm.. personally I feel like the consumer should be tolerating this...

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1813354, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1813354: OpenStack: Trim EOLs from the cacert trustbundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member Author

the consumer should be tolerating this

And indeed, the problem was in the loop that parsed the certificate chain. I have amended the patch, thanks.

/assign mandre

@pierreprinetti
Copy link
Member Author

/retitle Bug 1813354: OpenStack: Fix the cacert trustbundle parser

@openshift-ci-robot openshift-ci-robot changed the title Bug 1813354: OpenStack: Trim EOLs from the cacert trustbundle Bug 1813354: OpenStack: Fix the cacert trustbundle parser Jul 4, 2020
@pierreprinetti
Copy link
Member Author

/test e2e-openstack
:(

@mandre
Copy link
Member

mandre commented Jul 5, 2020

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Jul 5, 2020

/test e2e-openstack
Aww come on e2e-openstack, now what??

@pierreprinetti
Copy link
Member Author

/test e2e-openstack

@pierreprinetti
Copy link
Member Author

/retest

2 similar comments
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti pierreprinetti force-pushed the bz_1813354 branch 2 times, most recently from ec0e1b7 to ca8b10d Compare July 9, 2020 08:36
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/hold cancel
/assign mandre

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@pierreprinetti
Copy link
Member Author

@mandre PTAL

@mandre
Copy link
Member

mandre commented Jul 9, 2020

Looks good. Can we also add a test case for invalid certificate?

@pierreprinetti
OpenStack: Trim EOLs from the cacert trustbundle
0bf09af 
Fix a bug where a trailing empty line caused an error.
@mandre
Copy link
Member

mandre commented Jul 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 0bf09af link /test e2e-ovirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 85092be into openshift:master Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/installer#3840. Bugzilla bug 1813354 has been moved to the MODIFIED state.

In response to this:

Bug 1813354: OpenStack: Fix the cacert trustbundle parser

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bz_1813354 branch July 10, 2020 09:12
@pierreprinetti
Copy link
Member Author

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 10, 2020
Closed
@openshift-cherrypick-robot
Copy link

@pierreprinetti: new pull request created: #3873

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @openshift-ci-robot @mandre @abhinavdahiya @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot