Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/user/gcp/install_upi: Drop unused 'region' from compute #3847

Merged

Conversation

wking
Copy link
Member

@wking wking commented Jul 6, 2020

The consuming script has not been changed since it landed in cbe6f15 (#2117).

The associated Markdown landed with a 'region' in the docs and YAML in cbe6f15. It was removed from the YAML in 998a518 (#2574), but not the surrounding Markdown (until this commit).

Parallel openshift-docs fix in flight with openshift/openshift-docs#23500.

The consuming script has not been changed since it landed in
cbe6f15 (upi/gcp: initial deployment manager templates,
2019-07-29, openshift#2117).

The associated Markdown landed with a 'region' in the docs and YAML in
cbe6f15.  It was removed from the YAML in 998a518 (gcp upi:
split templates to simplify shared vpc workflow, 2019-10-25, openshift#2574),
but not the surrounding Markdown (until this commit).
@jstuever
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8159eed into openshift:master Jul 15, 2020
@wking wking deleted the drop-unused-compute-region branch November 4, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants