Bug 1853859: Add validations for IP inputs #3862
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@rna-afk: This pull request references Bugzilla bug 1853859, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-vsphere |
|
Needs install config (non-survey) validation too |
rna-afk
force-pushed
the
vsphere_check_ip_address
branch
4 times, most recently
from
43e1dc2
to
db4ce69
Compare
rna-afk
force-pushed
the
vsphere_check_ip_address
branch
from
db4ce69
to
97926ee
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rna-afk
force-pushed
the
vsphere_check_ip_address
branch
from
97926ee
to
782361b
Compare
|
LGTM but would like to run it through CI |
|
/test e2e-vsphere-upi |
| p.IngressVIP = "192.168.111.1" | ||
| return p | ||
| }(), | ||
| expectedError: `^test-path.IPs: Invalid value: "192.168.111.1": IPs for both API and Ingress should not be the same`, |
There was a problem hiding this comment.
| expectedError: `^test-path.IPs: Invalid value: "192.168.111.1": IPs for both API and Ingress should not be the same`, | |
| expectedError: `^test-path.apiVIP: Invalid value: "192.168.111.1": IPs for both API and Ingress should not be the same`, |
There was a problem hiding this comment.
^ this is why unit tests are failing
With the current setup, it is possible for the user to enter the same IP address for the ingress and the API for vsphere. Creating a cluster with these settings results in Bootstrap and one of the masters being assigned the same IP address during installation. Added a validation to check if the given input for the Ingress is not the same as API whose input would have been specified first and throw an error if they are the same, prompting the user to re-enter the IP address again.
rna-afk
force-pushed
the
vsphere_check_ip_address
branch
from
782361b
to
0f12e82
Compare
|
/test e2e-vsphere |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rna-afk: All pull requests linked via external trackers have merged: openshift/installer#3862. Bugzilla bug 1853859 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.5 |
|
@abhinavdahiya: new pull request created: #3875 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With the current setup, it is possible for the user to enter the
same IP address for the ingress and the API for vsphere. Creating
a cluster with these settings results in Bootstrap and one of the
masters being assigned the same IP address during installation.
Added a validation to check if the given input for the Ingress is
not the same as API whose input would have been specified first
and throw an error if they are the same, prompting the user to
re-enter the IP address again.