Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1852545: Add ResourcePoolPath to machines in vsphere #3863

Merged
merged 1 commit into from Jul 15, 2020
Merged

Bug 1852545: Add ResourcePoolPath to machines in vsphere #3863

merged 1 commit into from Jul 15, 2020

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Jul 8, 2020

In vsphere IPI installations, the VCenter can have multiple data centers and clusters.
When a new cluster is created, the machine-api operator fails to find a default resource
pool because there are multiple resource pools.

This will specify the exact path to reference the resources which will
remove this ambiguity and will not cause failure in the installation
process.

@rna-afk
vsphere: Add ResourcePoolPath information in the machineset
50b8801 
Vcenter can have multiple datacenters and clusters. When a new cluster
is created, the machine-api operator fails to find a default resource
pool because there are multiple and there is ambiguity in choice.

This will specify the exact path to reference the resources which will
remove this ambiguity and will not cause failure in the installation
process.
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Bugzilla bug 1852545, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1852545: Add ResourcePoolPath to machines in vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 8, 2020
@rna-afk
Copy link
Contributor Author

rna-afk commented Jul 8, 2020

/test e2e-vsphere

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@patrickdillon
Copy link
Contributor

/cc @jcpowermac

@patrickdillon
Copy link
Contributor

/test e2e-vsphere

@patrickdillon
Copy link
Contributor

/test e2e-vsphere-upi

@jcpowermac
Copy link
Contributor

jcpowermac commented Jul 9, 2020 •
edited

UPI the compute nodes didn't come up
IPI not 100% sure but the kube-api isn't responding

@rna-afk
Copy link
Contributor Author

rna-afk commented Jul 10, 2020

/test e2e-vsphere

1 similar comment
@rna-afk
Copy link
Contributor Author

rna-afk commented Jul 13, 2020

/test e2e-vsphere

@patrickdillon
Copy link
Contributor

/test e2e-vsphere
/test e2e-vsphere-upi

@patrickdillon
Copy link
Contributor

testing e2e-vsphere is blocked by openshift/cluster-etcd-operator#388

@rna-afk
Copy link
Contributor Author

rna-afk commented Jul 15, 2020

/test e2e-vsphere
/test e2e-vsphere-upi

@patrickdillon
Copy link
Contributor

/lgtm
Tested locally. Worker machines were successfully created. All clusteroperators available, but strange installation failure with

INFO Waiting up to 30m0s for bootstrapping to complete... 
INFO Cluster operator insights Disabled is False with AsExpected:  
INFO Cluster operator kube-apiserver Progressing is True with NodeInstaller: NodeInstallerProgressing: 1 nodes are at revision 5; 2 nodes are at revision 6 
INFO Pulling debug logs from the bootstrap machine 
INFO Bootstrap gather logs captured here "/home/padillon/go/src/github.com/openshift/installer/bin/vsphere-rpp/cluster/log-bundle-20200715142035.tar.gz" 
FATAL Bootstrap failed to complete: failed to wait for bootstrapping to complete: timed out waiting for the condition

seems unrelated to this bug

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@rna-afk: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 50b8801 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 50b8801 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-vsphere-upi 50b8801 link /test e2e-vsphere-upi
ci/prow/e2e-vsphere 50b8801 link /test e2e-vsphere
ci/prow/e2e-ovirt 50b8801 link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c91e656 into openshift:master Jul 15, 2020
@openshift-ci-robot
Copy link
Contributor

@rna-afk: All pull requests linked via external trackers have merged: openshift/installer#3863. Bugzilla bug 1852545 has been moved to the MODIFIED state.

In response to this:

Bug 1852545: Add ResourcePoolPath to machines in vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

@abhinavdahiya: new pull request created: #4014

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac jcpowermac mentioned this pull request Feb 23, 2021
Merged
bobfuru pushed a commit to openshift/openshift-docs that referenced this pull request Feb 25, 2021
@jcpowermac
vSphere - remove bullet statement about multiple dc, clusters
6f1d840 
This has been resolved since July and is causing customer
confusion. Removing bullet.

See: openshift/installer#3863
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Feb 25, 2021
@jcpowermac
vSphere - remove bullet statement about multiple dc, clusters
a07ecf7 
This has been resolved since July and is causing customer
confusion. Removing bullet.

See: openshift/installer#3863
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Feb 25, 2021
@jcpowermac
vSphere - remove bullet statement about multiple dc, clusters
ae86fa1 
This has been resolved since July and is causing customer
confusion. Removing bullet.

See: openshift/installer#3863
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Feb 25, 2021
@jcpowermac
vSphere - remove bullet statement about multiple dc, clusters
d701b37 
This has been resolved since July and is causing customer
confusion. Removing bullet.

See: openshift/installer#3863
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Feb 25, 2021
@jcpowermac
vSphere - remove bullet statement about multiple dc, clusters
d2d823a 
This has been resolved since July and is causing customer
confusion. Removing bullet.

See: openshift/installer#3863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@jstuever jstuever Awaiting requested review from jstuever

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rna-afk @openshift-ci-robot @abhinavdahiya @patrickdillon @jcpowermac @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot