Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upi/metal: Add pxe_kernel_args, stop using pxe_os_image_url #3865

Merged
merged 5 commits into from Aug 6, 2020
Merged

upi/metal: Add pxe_kernel_args, stop using pxe_os_image_url #3865

merged 5 commits into from Aug 6, 2020

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jul 8, 2020

This was referenced Jul 8, 2020
Closed
Merged
Merged
@sdodson
Copy link
Member Author

sdodson commented Jul 8, 2020

/hold for the blocker

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@sohankunkerkar
Copy link
Member

/retest

@sdodson
Copy link
Member Author

sdodson commented Jul 9, 2020

@sohankunkerkar Need to call out the specific test, it's not included by default right now because we don't have context specific jobs yet.
/test e2e-metal

@sohankunkerkar
Copy link
Member

@sohankunkerkar Need to call out the specific test, it's not included by default right now because we don't have context specific jobs yet.
/test e2e-metal

ah, thanks for the pointer.

abhinavdahiya
abhinavdahiya reviewed Jul 9, 2020
View reviewed changes
upi/metal/config.tf
@@ -132,13 +132,12 @@ EOF

}

variable "pxe_os_image_url" {
variable "pxe_kernel_args" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the user pass multiple args? if so can we include an example of that? and make sure it will actually work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support providing multiple arguments yes; there are various use cases for that, especially debugging. But I wouldn't block on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now they could, I assume by using a space delimited string, I assume there's a better type for this in tfvars?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is space separated, then can we show that as example in the description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also since you are changing the input variable, can you also update https://github.com/openshift/installer/blob/fa2d5bbe2ba00b36c697de7ff0658f51df36a20a/upi/metal/terraform.tfvars.example

and also updating docs on how to provide the os image url with this new input variable, maybe here https://github.com/openshift/installer/blob/fa2d5bbe2ba00b36c697de7ff0658f51df36a20a/docs/user/metal/install_upi.md#required-kernel-parameters-during-pxe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya Thanks, 0402482 should have docs updates. If there's a more backwards compatible manner to have made this change let me know if you think I should pursue other options.

sohankunkerkar
sohankunkerkar reviewed Jul 9, 2020
View reviewed changes
upi/metal/main.tf Outdated Show resolved Hide resolved
upi/metal/main.tf Outdated Show resolved Hide resolved
@sohankunkerkar
Copy link
Member

/test e2e-metal

sohankunkerkar
sohankunkerkar suggested changes Jul 10, 2020
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after looking at https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3865/pull-ci-openshift-installer-master-e2e-metal/1281237439557406720#1:build-log.txt%3A328, it looks like you'd need s/"${var.pxe_kernel_args}"/var.pxe_kernel_args

Looks like CI is still complaining about this failure.
How about adding pxe_kernel_args = var.pxe_kernel_args here and change s/var.pxe_kernel_args/local.pxe_kernel_args

@sohankunkerkar
Copy link
Member

/test e2e-metal

@sdodson
Copy link
Member Author

sdodson commented Jul 10, 2020 

Waiting for bootstrap to complete
level=info msg="Waiting up to 20m0s for the Kubernetes API at https://api.ci-op-ss4ghbmz-d3e37.origin-ci-int-aws.dev.rhcloud.com:6443..."

It's atleast made it that far, going to squash out my tf newbness now that it's working.

@sohankunkerkar
Copy link
Member

/test e2e-metal

1 similar comment
@sohankunkerkar
Copy link
Member

/test e2e-metal

@sdodson
Copy link
Member Author

sdodson commented Jul 10, 2020

/test e2e-metal

As long as a PR is opened by a member it will re-run tests on push. So it shouldn't be necessary to trigger it explicitly.

@sdodson
Copy link
Member Author

sdodson commented Jul 10, 2020

Of course as soon as I say that the job gets jammed up and doesn't run.
/test e2e-metal

@sohankunkerkar
Copy link
Member

/retest

1 similar comment
@sohankunkerkar
Copy link
Member

/retest

@sdodson
Copy link
Member Author

sdodson commented Jul 11, 2020

/test e2e-metal

@sohankunkerkar
Copy link
Member

/retest

1 similar comment
@sohankunkerkar
Copy link
Member

/retest

@sdodson sdodson force-pushed the metal-liveimage branch 2 times, most recently from d3f8212 to d89eaa0 Compare July 11, 2020 15:08
@sdodson
Copy link
Member Author

sdodson commented Jul 11, 2020

/test e2e-metal

@miabbott
Copy link
Member

miabbott commented Aug 5, 2020

error: no kind "CertificateSigningRequest" is registered for version "certificates.k8s.io/v1" in scheme "k8s.io/kubernetes/pkg/kubectl/scheme/scheme.go:28" seems to correspond to https://bugzilla.redhat.com/show_bug.cgi?id=1861828

@sdodson
Copy link
Member Author

sdodson commented Aug 5, 2020

/test e2e-metal

@sohankunkerkar
Copy link
Member

/retest

@sdodson
Copy link
Member Author

sdodson commented Aug 5, 2020

Now we've got https://bugzilla.redhat.com/show_bug.cgi?id=1861828 or https://bugzilla.redhat.com/show_bug.cgi?id=1860789

error: no kind "CertificateSigningRequest" is registered for version "certificates.k8s.io/v1" in scheme "k8s.io/kubernetes/pkg/kubectl/scheme/scheme.go:28"

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 5, 2020 •
edited

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/3865/pull-ci-openshift-installer-master-e2e-metal/1291088729330421760
list of unapproved CSRs

$ for i in $(curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/3865/pull-ci-openshift-installer-master-e2e-metal/1291088729330421760/artifacts/e2e-metal/csr.json | jq -r '.items[] | select(.status == {}) | .spec.request'); do echo "$i" | base64 -d | openssl req -noout -text; done
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-1.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:8c:11:03:49:9f:6d:10:7e:1f:ab:c6:1c:89:07:
                    6e:af:22:45:cb:fb:8d:27:66:4a:9c:23:13:2e:53:
                    31:fe:89:53:ee:c8:10:ad:2d:b8:8e:d4:14:73:e1:
                    29:74:20:29:17:9e:a3:a7:3d:f2:28:5a:4a:a7:69:
                    e2:cd:54:9f:73
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:45:02:21:00:9d:6c:39:5a:2f:ec:05:41:0b:8c:18:44:6b:
         9d:73:2b:b4:58:36:8d:db:70:75:11:9a:a8:5e:67:dc:8b:be:
         52:02:20:24:d5:07:a1:de:37:44:be:2c:b8:8d:e7:2e:a3:20:
         75:66:1d:3d:12:af:84:a6:4f:d1:8e:a8:9d:c6:ee:02:53
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-2.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:dd:97:03:c7:50:c8:47:d1:e5:6f:46:00:58:ab:
                    bb:17:57:d3:d6:b5:06:70:9e:fe:57:ba:2f:d9:c0:
                    a7:f6:91:08:dd:e3:8a:37:4c:74:5c:d7:9c:7a:d8:
                    a1:4e:d2:99:4e:f5:7c:26:ba:28:6b:18:f6:37:ed:
                    0b:c3:6e:93:ea
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:44:02:20:6f:14:35:aa:4e:9a:9d:d3:f9:84:02:57:04:e6:
         5e:4a:4c:81:cb:43:fd:14:15:3d:89:84:47:17:5e:23:c1:2d:
         02:20:6c:9a:c6:8d:cf:c7:2f:37:e2:0c:2d:b2:51:8b:79:48:
         30:5f:59:f4:e3:45:ce:81:a6:95:57:4a:ac:39:2e:3a
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-0.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:37:e0:48:69:59:84:19:55:5b:08:fe:73:ce:8e:
                    af:b7:f9:4d:70:3e:c1:58:21:a5:bb:05:17:59:de:
                    11:8d:76:64:30:b0:26:7f:61:a0:cc:e6:b7:14:90:
                    6c:03:bf:5f:2f:fe:55:c2:11:8e:c4:f7:63:7c:1e:
                    6e:4f:47:81:4a
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:45:02:21:00:ac:14:ff:8e:2d:4e:99:cc:be:dd:26:a9:bd:
         25:3e:e0:53:53:97:fe:72:1e:b8:19:d8:de:5f:67:c9:2c:e8:
         2a:02:20:76:af:1f:e1:35:af:e6:e5:c1:f3:80:78:7c:8d:02:
         bf:bd:34:7a:16:fd:33:37:82:66:cd:ee:20:d5:1a:a1:48
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-2.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:1e:35:19:4b:00:90:c7:85:47:18:c3:68:7c:70:
                    9d:55:dd:8d:b6:a0:7c:24:bd:d3:9e:fb:25:46:b3:
                    04:19:ee:00:2b:7e:ae:cd:89:24:7b:d5:44:b2:6f:
                    f4:f9:82:d2:67:cb:bd:5a:60:9d:8a:65:5a:9b:ba:
                    c0:5b:95:bb:1f
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:45:02:21:00:b9:cf:ea:3f:e9:26:ab:f6:fa:b0:eb:a1:80:
         e3:f2:c3:1e:d4:cd:24:86:d9:a0:10:06:0d:59:2a:91:35:99:
         ec:02:20:28:6a:cd:61:13:2b:7b:7e:41:96:53:cd:2e:79:b5:
         74:45:8a:52:fc:13:76:60:a4:af:c1:20:00:16:52:07:8d
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-0.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:d3:7d:dd:71:02:2a:5b:9d:33:5a:0b:44:03:4f:
                    6b:9c:bf:5a:f9:4e:12:27:58:30:d7:7f:15:bd:8a:
                    fe:9d:d0:8d:32:b8:df:a1:4f:db:16:ac:9c:64:96:
                    74:5c:01:38:ab:2a:5e:2f:c3:7d:a0:88:2a:dd:5f:
                    71:27:55:2e:58
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:44:02:20:74:f9:32:2a:48:7a:d7:97:11:4a:e9:a4:8a:a6:
         26:03:0d:77:bb:c9:7e:6f:1a:83:d6:73:9d:1d:27:9a:05:9c:
         02:20:54:d9:11:63:b2:5a:51:a4:e0:ec:cd:95:43:0f:44:7f:
         aa:fd:fa:17:5a:67:c5:28:34:f8:16:ab:41:89:0d:21
Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: O = system:nodes, CN = system:node:worker-1.ci-op-6qgtgdqn-d3e37.origin-ci-int-aws.dev.rhcloud.com
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:8f:61:23:cb:5a:2d:25:19:6d:2f:2f:c2:f9:c9:
                    d7:d5:01:bf:02:d0:18:c3:37:61:4b:72:f4:b3:40:
                    dc:a7:8e:7c:c4:df:43:b3:90:2b:0c:81:cb:2c:20:
                    cc:f2:48:5c:b8:b1:c0:8b:20:0e:ae:f7:34:a6:10:
                    6f:f2:f0:b7:b4
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        Attributes:
            a0:00
    Signature Algorithm: ecdsa-with-SHA256
         30:45:02:20:4e:16:1d:c7:db:fd:66:77:1a:aa:9f:6e:4a:de:
         92:38:40:8f:f9:1b:cd:94:ed:26:e9:5b:a1:27:50:fe:75:04:
         02:21:00:c9:6a:ac:ab:6e:fd:a5:b2:0d:9d:5d:aa:1e:a6:14:
         e2:42:39:3b:bb:45:cf:4e:59:3a:97:bb:ec:d6:80:b6:d8

So it looks like the nodes are booting and getting the ignition from the cluster and the kubelet runs to move to send CSRs but it not getting approved due to oc bug. So i'm fine moving ahead with this PR.

/approve
/lgtm

/hold
to allow other people to chime in, feel free to cancel the hold if you agree on moving ahead.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@sdodson
Copy link
Member Author

sdodson commented Aug 5, 2020

I'm fine, this really doesn't change anything until we land the release repo changes so moving forward.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 6, 2020 •
edited

@sdodson: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 4bc5a88 link /test e2e-ovirt
ci/prow/e2e-metal 4bc5a88 link /test e2e-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member Author

sdodson commented Aug 6, 2020

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member Author

sdodson commented Aug 6, 2020

/override ci/prow/e2e-libvirt
/override ci/prow/e2e-crc
/override ci/prow/e2e-aws-workers-rhel7
/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-metal-ipi

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-fips, ci/prow/e2e-aws-workers-rhel7, ci/prow/e2e-crc, ci/prow/e2e-libvirt, ci/prow/e2e-metal-ipi

In response to this:

/override ci/prow/e2e-libvirt
/override ci/prow/e2e-crc
/override ci/prow/e2e-aws-workers-rhel7
/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1da6208 into openshift:master Aug 6, 2020
@sohankunkerkar sohankunkerkar mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

@bgilbert bgilbert bgilbert left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@sohankunkerkar sohankunkerkar sohankunkerkar requested changes

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sdodson @sohankunkerkar @miabbott @abhinavdahiya @openshift-ci-robot @openshift-bot @cgwalters @bgilbert @openshift-merge-robot