New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1848987: Add hint to switch username #3880
Bug 1848987: Add hint to switch username #3880
Conversation
@gekorob: This pull request references Bugzilla bug 1848987, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment but looks good.
@@ -97,12 +97,18 @@ func (c *clientHTTP) checkURLResponse() error { | |||
// askPassword will ask the password to connect to Engine API. | |||
// The password provided will be added in the Config struct. | |||
// If an error happens, it will ask again username for users. | |||
func askPassword(c *Config) error { | |||
func askPassword(c *Config, hintMsg string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need hintMsg as param for a askPassword() function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No pb I'll remove it
Add hint message to notify the user that with Ctrl+C is possible to switch the username already choosen
bb9b46b
to
da5823c
Compare
/lgtm |
/retest |
@gekorob: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I have also verified the patch. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gekorob: All pull requests linked via external trackers have merged: openshift/installer#3880. Bugzilla bug 1848987 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add hint message to notify the user that with Ctrl+C is possible to
switch the username already choosen
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1848987