New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1857169: ovirt: Use NetworkManager instead of dhclient in bootstrap #3892
Bug 1857169: ovirt: Use NetworkManager instead of dhclient in bootstrap #3892
Conversation
Latest RHCOS dropped dhclient binary and now the way to prepend 127.0.0.1 to /etc/resolv.conf would be using NM dispatcher script Signed-off-by: Roy Golan <rgolan@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local environment and the prepend is working for the /etc/resolve.conf
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gekorob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rgolangh: This pull request references Bugzilla bug 1857169, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla-refresh |
/bugzilla refresh |
@rgolangh: This pull request references Bugzilla bug 1857169, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@rgolangh: All pull requests linked via external trackers have merged: openshift/installer#3892. Bugzilla bug 1857169 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Latest RHCOS dropped dhclient binary and now the way to prepend
127.0.0.1 to /etc/resolv.conf would be using NM dispatcher script
Signed-off-by: Roy Golan rgolan@redhat.com