Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1857651: oVirt, add condition for non existing tmp-vm #3897

Merged

Conversation

Gal-Zaidman
Copy link
Contributor

@Gal-Zaidman Gal-Zaidman commented Jul 16, 2020

PR #3868 added the tmp vm as an output variable. This causes the installer to fail when that resource is not created i.e when we don't let the installer create the template, as we do on CI.
This caused all 4.6 and master PR to be red and fail before starting the installation.
We need to fix and add a condition to set the var only when the resource is created

Signed-off-by: Gal-Zaidman gzaidman@redhat.com

@Gal-Zaidman Gal-Zaidman force-pushed the remove-index-from-tmp-vm branch 3 times, most recently from ea6eb17 to 15b9b6c Compare July 16, 2020 08:24
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
@Gal-Zaidman Gal-Zaidman changed the title TEST: remove index from tmp vm resource oVirt: add condition for non existing tmp-vm Jul 16, 2020
@Gal-Zaidman Gal-Zaidman changed the title oVirt: add condition for non existing tmp-vm Bug 1857651: oVirt, add condition for non existing tmp-vm Jul 16, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: This pull request references Bugzilla bug 1857651, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1857651: oVirt, add condition for non existing tmp-vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: This pull request references Bugzilla bug 1857651, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1857651: oVirt, add condition for non existing tmp-vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor Author

/retest

@gekorob
Copy link
Contributor

gekorob commented Jul 16, 2020

Tested locally with the template creation flow and it worked

@gekorob
Copy link
Contributor

gekorob commented Jul 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@gekorob
Copy link
Contributor

gekorob commented Jul 16, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dougsland
Copy link
Contributor

/lgtm

@dougsland
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland, gekorob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 07a9642 into openshift:master Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/installer#3897. Bugzilla bug 1857651 has been moved to the MODIFIED state.

In response to this:

Bug 1857651: oVirt, add condition for non existing tmp-vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants