New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1857651: oVirt, add condition for non existing tmp-vm #3897
Bug 1857651: oVirt, add condition for non existing tmp-vm #3897
Conversation
ea6eb17
to
15b9b6c
Compare
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
15b9b6c
to
af1a170
Compare
@Gal-Zaidman: This pull request references Bugzilla bug 1857651, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Gal-Zaidman: This pull request references Bugzilla bug 1857651, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Tested locally with the template creation flow and it worked |
/lgtm |
/approve |
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland, gekorob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/installer#3897. Bugzilla bug 1857651 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR #3868 added the tmp vm as an output variable. This causes the installer to fail when that resource is not created i.e when we don't let the installer create the template, as we do on CI.
This caused all 4.6 and master PR to be red and fail before starting the installation.
We need to fix and add a condition to set the var only when the resource is created
Signed-off-by: Gal-Zaidman gzaidman@redhat.com