baremetal: populate TypeMeta for baremetal provider config #3907
Conversation
|
/label platform/baremetal |
|
/test golint |
|
/lgtm |
|
CI is cranky today /test images |
|
/test e2e-metal-ipi Timeout mirroring images. |
|
This is still failing for me locally: failed to fetch Cluster: failed to fetch dependency of "Cluster": failed to generate asset "Platform Quota Check": unmarshal master 0: no kind "BareMetalMachineProviderSpec" is registered for version "baremetalproviderconfig.openshift.io/v1alpha1" in scheme "github.com/openshift/installer/pkg/asset/machines/master.go:459" |
Currently, we're not setting Kind or APIVersion in the baremetal provider config, which is causing problems when recent code added to the installer tries to unmarshal these resources. o
stbenjam
force-pushed
the
fix-provider-spec
branch
from
cd07be9
to
cf80ede
Compare
Different error though, looks like I had the wrong group version. I guess it's |
|
/lgtm Deployment is still running, but this at least got me past where it failed before. |
|
/test images |
|
/approve I doubt I can do this, but the bots did ask me for approval! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Oh I can. Thanks bots! |
|
/test e2e-aws-upgrade |
1 similar comment
|
/test e2e-aws-upgrade |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Currently, we're not setting Kind or APIVersion in the baremetal
provider config, which is causing problems when recent code added to the
installer tries to unmarshal these resources.
Fixes #3906