Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1857945: ovirt: if TLS verify is disable raise a question to users #3909

Merged
merged 1 commit into from Jul 21, 2020
Merged

Bug 1857945: ovirt: if TLS verify is disable raise a question to users #3909

merged 1 commit into from Jul 21, 2020

Conversation

dougsland
Copy link
Contributor

Today if the installer cannot download the CA from Engine
it will continue without enabling TLS verify (connection Insecure).
Instead of warning only, let's make sure users agree with that.

Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1857945
Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

@dougsland
Copy link
Contributor Author

/retest

@sandrobonazzola
Copy link

Has this been verified?

@gekorob
Copy link
Contributor

gekorob commented Jul 17, 2020

Not yet by my side I'll verify it locally this afternoon.

@gekorob
Copy link
Contributor

gekorob commented Jul 17, 2020

/assign

@dougsland
Copy link
Contributor Author

Has this been verified?

Yes, I only send patches that I have verified. If for some reason there is a corner case should be catch by CI.

@dougsland dougsland changed the title ovirt: if TLS verify is disable raise a question to users Bug 1857945: ovirt: if TLS verify is disable raise a question to users Jul 17, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 17, 2020
@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Bugzilla bug 1857945, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1857945: ovirt: if TLS verify is disable raise a question to users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 17, 2020
@dougsland
ovirt: if TLS verify is disable raise a question to users
9afe5fc 
Today if the installer cannot download the CA from Engine
it will continue without enabling TLS verify (connection Insecure).
Instead of warning only, let's make sure users agree with that.

Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1857945
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

Please consider merging this patch first as dependency: #3908

@dougsland
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@gekorob
Copy link
Contributor

gekorob commented Jul 17, 2020

/lgtm
Merge only after the #3908

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@dougsland
Copy link
Contributor Author

/retest

@dougsland dougsland mentioned this pull request Jul 18, 2020
Closed
@dougsland
Copy link
Contributor Author

/unhold dep. patch merged

@dougsland
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@dougsland
Copy link
Contributor Author

/retest

1 similar comment
@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/test e2e-libvirt

@gekorob
Copy link
Contributor

gekorob commented Jul 21, 2020

/retest

1 similar comment
@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/test e2e-libvirt

@gekorob
Copy link
Contributor

gekorob commented Jul 21, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gekorob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/test e2e-aws
/test e2e-libvirt

@dougsland
Copy link
Contributor Author

/test e2e-libvirt

@openshift-ci-robot
Copy link
Contributor

@dougsland: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9afe5fc link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 71b58b8 into openshift:master Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

@dougsland: All pull requests linked via external trackers have merged: openshift/installer#3909. Bugzilla bug 1857945 has been moved to the MODIFIED state.

In response to this:

Bug 1857945: ovirt: if TLS verify is disable raise a question to users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gekorob gekorob Awaiting requested review from gekorob

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@gekorob gekorob

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dougsland @sandrobonazzola @gekorob @openshift-ci-robot @openshift-bot @openshift-merge-robot