baremetal: create machines and machineset linked to cluster #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installer takes the cluster name given by the user and appends a random string. MachineSets and Machines create within the cluster need to be linked to that cluster in order to be recognized by some of the controllers in the machine API. This is especially important, for example, when scaling a MachineSet to ensure that the new Machines created by the machine-set-controller are linked to the MachineSet properly. See https://bugzilla.redhat.com/show_bug.cgi?id=1857175 for more details. This change drops the use of cluster name in the MachineSet and Machine resoures created for a baremetal cluster and uses the clusterID instead. The baremetal platform was the only one using name instead of ID in this way. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
/test images |
|
/test e2e-aws-fips |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer takes the cluster name given by the user and appends a
random string. MachineSets and Machines create within the cluster need
to be linked to that cluster in order to be recognized by some of the
controllers in the machine API. This is especially important, for
example, when scaling a MachineSet to ensure that the new Machines
created by the machine-set-controller are linked to the MachineSet
properly. See https://bugzilla.redhat.com/show_bug.cgi?id=1857175 for
more details.
This change drops the use of cluster name in the MachineSet and
Machine resoures created for a baremetal cluster and uses the
clusterID instead. The baremetal platform was the only one using name
instead of ID in this way.