baremetal: Only set BMC secret reference in Hosts when BMC details are specified

[kirankt]

This PR ensures that BMC secret is referenced in the hosts asset only when BMC credentials are specified. If not, the secret is not referenced.

[kirankt]

/assign @stbenjam

[kirankt]

/assign @stbenjam

[stbenjam]

/approve

Could we get one of the assisted installer folks who reporter this to have a look as well? Or maybe @hardys

[stbenjam]

One other nit, can you fix the commit message to match the PR title, and include the description you have as well.

https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format

[kirankt]

@yevgeny-shnaidman Can you please take a look and see if this PR works for you? Thanks.

[kirankt]

/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/machines/baremetal/OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@kirankt: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	ce2b79c	link	/test e2e-libvirt
ci/prow/e2e-crc	ce2b79c	link	/test e2e-crc
ci/prow/e2e-aws-fips	ce2b79c	link	/test e2e-aws-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.