New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1855345: ovirt: show more info about PEM file loaded #3940
Conversation
@dougsland: This pull request references Bugzilla bug 1855345, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works.
I tried letting the installer downloading the PEM and also pasting my PEM.
Just a note. When the PEM downloaded is summarized in the output
INFO Loaded the follow PEM file:
INFO Version: 3
INFO Signature Algorithm: SHA256-RSA
I'd put Loaded the following PEM file
.
This patch show to users the PEM loaded automatic and ask to confirm. If users decide to not use the auto download PEM from Engine they can use their own PEM. Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1855345 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
/lgtm |
/test e2e-ovirt |
/retest |
/test e2e-ovirt |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gekorob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dougsland: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-crc |
@dougsland: All pull requests linked via external trackers have merged: openshift/installer#3940. Bugzilla bug 1855345 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch show to users the PEM loaded automatic and ask
to confirm. If users decide to not use the auto downloaded
PEM from Engine they can use their own PEM.
Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1855345
Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com