Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masters-gather: Include the full logs of failed units #3942

Merged
merged 1 commit into from Jul 22, 2020
Merged

Masters-gather: Include the full logs of failed units #3942

merged 1 commit into from Jul 22, 2020

Conversation

beekhof
Copy link
Contributor

@beekhof beekhof commented Jul 22, 2020

Signed-off-by: Andrew Beekhof andrew@beekhof.net

@beekhof beekhof changed the title Include the full logs of failed units Masters-gather: Include the full logs of failed units Jul 22, 2020
@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

Not convinced the codegen test failure has anything to do with this PR

@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

/test verify-codegen

wking
wking reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

/test e2e-aws-fips

@wking
Copy link
Member

wking commented Jul 22, 2020

/approve

Forgot I need to do that explicitly for the installer, instead of /lgtm implying it.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 22, 2020
@wking
Copy link
Member

wking commented Jul 22, 2020

Probably copy any changes into data/data/bootstrap/files/usr/local/bin/installer-gather.sh too, in case something blows up on the bootstrap machine.

@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

reworked to send journalctl output to its own file

@beekhof
Include the full logs of failed units
4e60294 
Signed-off-by: Andrew Beekhof <andrew@beekhof.net>
@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

/retest

1 similar comment
@beekhof
Copy link
Contributor Author

beekhof commented Jul 22, 2020

/retest

@ashcrow
Copy link
Member

ashcrow commented Jul 22, 2020

/retest

(not required, but curious)

ashcrow
ashcrow approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sdodson @abhinavdahiya

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jul 22, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e43e39a into openshift:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@ashcrow ashcrow ashcrow approved these changes

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@beekhof @wking @ashcrow @openshift-ci-robot @openshift-bot @openshift-merge-robot