use correct base URI for other azure cloud environments #3946
Conversation
When support for other Azure cloud environments was added [1], there were some necessary changes that were omitted. * Azure clients that are created need to use the base URI appropriate for the cloud environment. * Azure authorizers need to use the ActiveDirectory endpoint appropriate for the cloud environment. * The environment needs to be specified for the terraform azureprivatedns provider. [1] openshift#3634
|
/test e2e-azure |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@staebler: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
When support for other Azure cloud environments was added [1], there were some necessary changes that were omitted.
[1] #3634