Flavor validations #3953
Flavor validations #3953
Conversation
openshift-ci-robot
requested review from
pierreprinetti,
Fedosin,
mandre and
adduarte
|
@iamemilio: GitHub didn't allow me to request PR reviews from the following users: for, review. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
iamemilio
force-pushed
the
flavorValidations
branch
from
479d4fd
to
6492393
Compare
|
/label platform/openstack |
iamemilio
force-pushed
the
flavorValidations
branch
2 times, most recently
from
75cef44
to
ab60988
Compare
|
/retest |
1 similar comment
|
/retest |
openshift-ci-robot
added
the
needs-rebase
iamemilio
force-pushed
the
flavorValidations
branch
from
ab60988
to
82fbd94
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iamemilio
force-pushed
the
flavorValidations
branch
from
82fbd94
to
f42f78e
Compare
|
/lgtm |
|
/test e2e-openstack |
|
/test e2e-aws |
|
/retest |
| }(), | ||
| cloudInfo: validMpoolCloudInfo(), | ||
| expectedError: true, | ||
| expectedErrMsg: "compute.0..platform.openstack.flavorName: Not found: \"non-existant-flavor\"", |
There was a problem hiding this comment.
The two dots in compute.0..platform.openstack.flavorName is confusing, I suppose it works because it's a regex. Shouldn't it be something like compute\[0\]\.platform\.openstack\.flavorName instead?
There was a problem hiding this comment.
yeah but it complained when I tried to escape the bracket character. The effect is the same
There was a problem hiding this comment.
Ah I actually figured out how to do this right, I'll just fix it
| expectedErrMsg: "controlPlane.platform.openstack.flavorName: Not found: \"non-existant-flavor\"", | ||
| }, | ||
| { | ||
| name: "not found control plane flavorName", |
There was a problem hiding this comment.
the name does not match the test.
| name: "invalid platform flavor", | ||
| platform: func() *openstack.Platform { | ||
| p := validPlatform() | ||
| p.FlavorName = validComputeFlavor |
There was a problem hiding this comment.
I suggest you instead use invalidCtrlPlaneFlavor, where you can set all the values to be lower than required. You can also drop validComputeFlavor and invalidComputeFlavor that are not used for platform flavors.
There was a problem hiding this comment.
My thinking here was that if they opt to use a default, then it has to meet the minimum requirement for both the master and workers. And since the master has higher requirements, then that is the bound we should test for.
|
/retest |
Check that a minimum set of requirements are met for flavors to ensure that installation failures due to insufficient resources don't occur.
iamemilio
force-pushed
the
flavorValidations
branch
from
f42f78e
to
47006ef
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/hold cancel e2e openstack passing, code localized to openstack validations |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@iamemilio: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Check that a minimum set of requirements are met for flavors to ensure
that installation failures due to insufficient resources don't occur.
Stacked on top of my AZ pull request because this builds on top of the testing groundwork laid in that patch.
/cc @pierreprinetti @Fedosin @mandre @adduarte for review