Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: baremetal worker documentation #3955

Merged
merged 1 commit into from Aug 13, 2020
Merged

OpenStack: baremetal worker documentation #3955

merged 1 commit into from Aug 13, 2020

Conversation

adduarte
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2020
@adduarte adduarte force-pushed the baremetal_worker_documentation branch from 2b6b796 to d0d863f Compare July 29, 2020 16:22
pierreprinetti
pierreprinetti reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document clearly describes the steps from the user perspective, I like it!

A note about the case "Deploy cluster with vm workers only and add BM workers after": shouldn't we mention that connectivity between the two subnets is left to the responsibility of the user?

docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
@adduarte adduarte force-pushed the baremetal_worker_documentation branch from d0d863f to aa9369f Compare July 31, 2020 06:47
pierreprinetti
pierreprinetti reviewed Jul 31, 2020
View reviewed changes
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
docs/user/openstack/deploy_baremetal_workers.md Outdated Show resolved Hide resolved
@pierreprinetti
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@adduarte adduarte force-pushed the baremetal_worker_documentation branch from aa9369f to 062f7ca Compare August 4, 2020 06:45
pierreprinetti
pierreprinetti reviewed Aug 7, 2020
View reviewed changes
docs/user/openstack/deploy_baremetal_workers.md Outdated
attached to the tenant network provisioned by the installer.

- Requirements:
- Cloud provider is configure to allow creation of OpenStack subnets that support attaching vms and baremental machines to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be "bare metal"

@adduarte adduarte force-pushed the baremetal_worker_documentation branch 2 times, most recently from e5b8492 to 8652965 Compare August 11, 2020 08:16
@adduarte adduarte force-pushed the baremetal_worker_documentation branch from 8652965 to e65b5b8 Compare August 12, 2020 23:31
@adduarte adduarte changed the title [WIP] OpenStack: baremetal worker documentation OpenStack: baremetal worker documentation Aug 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2020
@stbenjam stbenjam mentioned this pull request Aug 13, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

@adduarte: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi e65b5b8 link /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 e65b5b8 link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc e65b5b8 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit c52bc55 into openshift:master Aug 13, 2020
@pierreprinetti pierreprinetti deleted the baremetal_worker_documentation branch August 13, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adduarte @pierreprinetti @openshift-ci-robot @openshift-merge-robot