Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ovirt Upi docs fix #3972

Merged
merged 2 commits into from Jul 30, 2020
Merged

Ovirt Upi docs fix #3972

merged 2 commits into from Jul 30, 2020

Conversation

gekorob
Copy link
Contributor

@gekorob gekorob commented Jul 29, 2020

Fix some typos and better specify the oVirt roles needed

Roberto Ciatti added 2 commits July 29, 2020 16:06
Fix typos
6205cc0 
Ingress IP was associated with the wrong DNS entry.
Typo fixed

Signed-off-by: Roberto Ciatti <rciatti@redhat.com>
Specify better the oVirt Roles needed
4d3d08b 
In particular it's the oVirt.vm-infra role that is needed and not the
oVirt.infra

Signed-off-by: Roberto Ciatti <rciatti@redhat.com>
@gekorob
Copy link
Contributor Author

gekorob commented Jul 29, 2020

/retest

@dougsland
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@dougsland
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2020 •
edited

@gekorob: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 4d3d08b link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e1a76ab into openshift:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@dougsland dougsland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gekorob @dougsland @openshift-ci-robot @openshift-bot @openshift-merge-robot