Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ovirt UPI: Start vms with async #3973

Merged
merged 1 commit into from Jul 30, 2020
Merged

Ovirt UPI: Start vms with async #3973

merged 1 commit into from Jul 30, 2020

Conversation

gekorob
Copy link
Contributor

@gekorob gekorob commented Jul 29, 2020

Add the async to the ansible tasks starting vms,
to have all vms starting in parallel

Signed-off-by: Roberto Ciatti rciatti@redhat.com

@gekorob
Copy link
Contributor Author

gekorob commented Jul 29, 2020

/retest

dougsland
dougsland suggested changes Jul 29, 2020
View reviewed changes
:wq Outdated
@@ -0,0 +1,22 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file name and path looks incorrect. :wq ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, good catch, thx a lot @dougsland

Start vms with async
4084586 
Add the async to the ansible tasks starting vms,
to have all vms starting in parallel

Signed-off-by: Roberto Ciatti <rciatti@redhat.com>
@gekorob
Copy link
Contributor Author

gekorob commented Jul 30, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@gekorob: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 4084586 link /test e2e-crc
ci/prow/e2e-ovirt 4084586 link /test e2e-ovirt
ci/prow/e2e-openstack 4084586 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 4084586 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 4084586 link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dougsland
dougsland approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit b1f19ae into openshift:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland approved these changes

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@dougsland dougsland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gekorob @openshift-ci-robot @dougsland @openshift-merge-robot