Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1865707: [baremetal] Add host roles to hosts in baremetal survey #4005

Merged
merged 1 commit into from Aug 11, 2020
Merged

Bug 1865707: [baremetal] Add host roles to hosts in baremetal survey #4005

merged 1 commit into from Aug 11, 2020

Conversation

kirankt
Copy link
Contributor

@kirankt kirankt commented Aug 4, 2020

This PR fixes a bug in the baremetal survey where the host role is not currently
set. We also change the phrase for control plane back to 'master' temporarily until
the whole ecosystem moves away from the 'master/slave' terminology.

@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Aug 4, 2020
@kirankt kirankt changed the title Bug 1865707 [baremetal] Add host roles to hosts in baremetal survey Bug 1865707: [baremetal] Add host roles to hosts in baremetal survey Aug 4, 2020
@openshift-ci-robot
Copy link
Contributor

@kirankt: This pull request references Bugzilla bug 1865707, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1865707: [baremetal] Add host roles to hosts in baremetal survey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 4, 2020
@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/test e2e-metal-ipi

@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/assign @stbenjam

@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/retest

@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/test e2e-metal-ipi

@stbenjam
Copy link
Member

stbenjam commented Aug 4, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@stbenjam
Copy link
Member

stbenjam commented Aug 4, 2020

/test e2e-metal-ipi

1 similar comment
@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/test e2e-metal-ipi

@kirankt
Copy link
Contributor Author

kirankt commented Aug 4, 2020

/retest

1 similar comment
@kirankt
Copy link
Contributor Author

kirankt commented Aug 5, 2020

/retest

@kirankt
Copy link
Contributor Author

kirankt commented Aug 5, 2020

/test e2e-metal-ipi

@kirankt
Copy link
Contributor Author

kirankt commented Aug 5, 2020

/retest

1 similar comment
@kirankt
Copy link
Contributor Author

kirankt commented Aug 5, 2020

/retest

@kirankt
Copy link
Contributor Author

kirankt commented Aug 5, 2020

/test e2e-metal-ipi

@kirankt
Copy link
Contributor Author

kirankt commented Aug 6, 2020

/retest

@stbenjam
Copy link
Member

stbenjam commented Aug 6, 2020

/test e2e-metal-ipi

1 similar comment
@kirankt
Copy link
Contributor Author

kirankt commented Aug 6, 2020

/test e2e-metal-ipi

@kirankt
Copy link
Contributor Author

kirankt commented Aug 7, 2020

/retest

1 similar comment
@kirankt
Copy link
Contributor Author

kirankt commented Aug 10, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kirankt
Copy link
Contributor Author

kirankt commented Aug 11, 2020

/retest

@kirankt
Copy link
Contributor Author

kirankt commented Aug 11, 2020

/test e2e-aws-scaleup-rhel7

@openshift-ci-robot
Copy link
Contributor

@kirankt: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test shellcheck
  • /test tf-fmt
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

Use /test all to run the following jobs:

  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-master-e2e-crc
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test e2e-aws-scaleup-rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kirankt
Bug 1865707. Add host roles to hosts in baremetal survey
5e0fccc 
This PR fixes a bug in the baremetal survey where the host role is not currently
set. If the choice is "control plane" the host role is "master" or else it will
be a "worker".
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@stbenjam
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

@kirankt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 a7bfd86 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-crc a7bfd86 link /test e2e-crc
ci/prow/e2e-libvirt a7bfd86 link /test e2e-libvirt
ci/prow/e2e-ovirt 5e0fccc link /test e2e-ovirt
ci/prow/e2e-openstack 5e0fccc link /test e2e-openstack
ci/prow/e2e-metal-ipi 5e0fccc link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cf41ff5 into openshift:master Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

@kirankt: All pull requests linked via external trackers have merged: openshift/installer#4005. Bugzilla bug 1865707 has been moved to the MODIFIED state.

In response to this:

Bug 1865707: [baremetal] Add host roles to hosts in baremetal survey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@hardys hardys Awaiting requested review from hardys

@markmc markmc Awaiting requested review from markmc

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kirankt @openshift-ci-robot @stbenjam @openshift-bot @openshift-merge-robot