bug 1866925: pkg/destroy/azure: fail fast if unable to list resources for any reason #4025

jhixson74 · 2020-08-07T20:53:34Z

https://bugzilla.redhat.com/show_bug.cgi?id=1866925

openshift-ci-robot · 2020-08-07T20:53:40Z

@jhixson74: This pull request references Bugzilla bug 1866925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1866925: pkg/destroy/azure: fail fast if unable to list resources for any reason

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhixson74 · 2020-08-07T20:55:25Z

/test e2e-azure

jhixson74 · 2020-08-07T22:47:36Z

/test e2e-azure

jhixson74 · 2020-08-10T17:22:38Z

/test e2e-azure

pkg/destroy/azure/azure.go

jhixson74 · 2020-08-22T02:02:54Z

/test e2e-azure

jhixson74 · 2020-08-22T17:36:26Z

/test e2e-azure

jhixson74 · 2020-08-23T20:58:56Z

/test e2e-azure

jhixson74 · 2020-08-25T00:15:36Z

/test e2e-azure

jhixson74 · 2020-08-25T21:10:55Z

/test e2e-azure

jhixson74 · 2020-08-26T20:56:35Z

/test e2e-azure

jhixson74 · 2020-08-27T16:47:17Z

/test e2e-azure

jhixson74 · 2020-08-28T03:18:50Z

/test e2e-azure

jhixson74 · 2020-08-31T23:13:22Z

/test e2e-azure

jhixson74 · 2020-09-01T19:56:10Z

/test e2e-azure

jhixson74 · 2020-09-01T23:05:27Z

/test e2e-azure

jhixson74 · 2020-09-02T17:28:38Z

/test e2e-azure

abhinavdahiya

This is looking good mostly, just few questions and suggestions

pkg/destroy/azure/azure.go

jhixson74 · 2020-09-02T23:45:34Z

/test e2e-azure

jhixson74 · 2020-09-03T04:50:00Z

/test e2e-azure

jhixson74 · 2020-09-03T17:29:41Z

/test e2e-azure

openshift-ci-robot · 2020-09-09T02:10:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/destroy/azure/OWNERS~~ [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhinavdahiya · 2020-09-09T02:11:13Z

/hold

To make sure e2e-azure goes green. John feel free to /hold cancel when it turns green. Thanks!

abhinavdahiya · 2020-09-09T06:40:07Z

/hold cancel

openshift-bot · 2020-09-09T06:50:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T07:04:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T08:23:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T08:48:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T09:13:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T10:32:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T10:58:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T11:36:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T11:49:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T12:42:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T13:59:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T14:12:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T15:56:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T16:10:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T16:35:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T18:19:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T18:32:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-09T19:17:52Z

@jhixson74: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	`837d04a`	link	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-09T19:24:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-09T19:45:41Z

@jhixson74: All pull requests linked via external trackers have merged:

openshift/installer#4025

Bugzilla bug 1866925 has been moved to the MODIFIED state.

In response to this:

bug 1866925: pkg/destroy/azure: fail fast if unable to list resources for any reason

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 7, 2020

openshift-ci-robot requested review from jim-minter and mjudeikis August 7, 2020 20:53

abhinavdahiya reviewed Aug 18, 2020

View reviewed changes

pkg/destroy/azure/azure.go Outdated Show resolved Hide resolved

jhixson74 force-pushed the master_azure_robust_destroy branch from 90234e0 to 28a4308 Compare August 22, 2020 02:02

jhixson74 force-pushed the master_azure_robust_destroy branch from 28a4308 to a4a2261 Compare August 25, 2020 21:01

jhixson74 force-pushed the master_azure_robust_destroy branch from a4a2261 to d6ce465 Compare August 28, 2020 03:18

jhixson74 force-pushed the master_azure_robust_destroy branch from d6ce465 to e8bd0cf Compare September 1, 2020 23:05

abhinavdahiya reviewed Sep 2, 2020

View reviewed changes

jhixson74 force-pushed the master_azure_robust_destroy branch from e8bd0cf to 1c558ff Compare September 2, 2020 23:45

openshift-ci-robot assigned abhinavdahiya Sep 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020

openshift-merge-robot merged commit ae7b03f into openshift:master Sep 9, 2020

openshift-ci-robot mentioned this pull request Oct 31, 2020

Bug 1866925: display Azure destroy auth error #4331

Merged

bug 1866925: pkg/destroy/azure: fail fast if unable to list resources for any reason #4025

bug 1866925: pkg/destroy/azure: fail fast if unable to list resources for any reason #4025

Conversation

jhixson74 commented Aug 7, 2020

openshift-ci-robot commented Aug 7, 2020

jhixson74 commented Aug 7, 2020

jhixson74 commented Aug 7, 2020

jhixson74 commented Aug 10, 2020

jhixson74 commented Aug 22, 2020

jhixson74 commented Aug 22, 2020

jhixson74 commented Aug 23, 2020

jhixson74 commented Aug 25, 2020

jhixson74 commented Aug 25, 2020

jhixson74 commented Aug 26, 2020

jhixson74 commented Aug 27, 2020

jhixson74 commented Aug 28, 2020

jhixson74 commented Aug 31, 2020

jhixson74 commented Sep 1, 2020

jhixson74 commented Sep 1, 2020

jhixson74 commented Sep 2, 2020

abhinavdahiya left a comment

Choose a reason for hiding this comment

jhixson74 commented Sep 2, 2020

jhixson74 commented Sep 3, 2020

jhixson74 commented Sep 3, 2020

openshift-ci-robot commented Sep 9, 2020

abhinavdahiya commented Sep 9, 2020

abhinavdahiya commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-ci-robot commented Sep 9, 2020 • edited

openshift-bot commented Sep 9, 2020

openshift-ci-robot commented Sep 9, 2020

openshift-ci-robot commented Sep 9, 2020 •

edited