Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1869329: OpenStack: Place Bootstrap in one of the master AZs #4056

Merged
merged 1 commit into from Aug 17, 2020
Merged

Bug 1869329: OpenStack: Place Bootstrap in one of the master AZs #4056

merged 1 commit into from Aug 17, 2020

Conversation

yussufsh
Copy link
Contributor

Provision bootstrap instance in given availability zone similar to masters. Currently bootstrap is created in default zone.

Signed-off-by: Yussuf Shaikh yussuf@us.ibm.com

@yussufsh
Copy link
Contributor Author

/label platform/openstack

@yussufsh
Copy link
Contributor Author

@iamemilio @Fedosin FYI

@pierreprinetti
Copy link
Member

Thank you, this makes a lot of sense.

/approve
/cc @mandre @iamemilio

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@pierreprinetti
Copy link
Member

/retitle Bug 1869329: OpenStack: Bootstrap server in the masters AZ

@openshift-ci-robot openshift-ci-robot changed the title Openstack: Provision bootstrap instance in given AZ similar to masters Bug 1869329: OpenStack: Bootstrap server in the masters AZ Aug 17, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@yussufsh: This pull request references Bugzilla bug 1869329, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1869329: OpenStack: Bootstrap server in the masters AZ

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Aug 17, 2020

/lgtm

Thanks! Looks like an overlook from #3918. We added the zone variable to the bootstrap module but never used it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member

Our linter is very picky... @yussufsh can you please make the required indentation change?

@pierreprinetti
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@pierreprinetti
Copy link
Member

/retitle Bug 1869329: OpenStack: Place Bootstrap in one of the master AZs

@openshift-ci-robot openshift-ci-robot changed the title Bug 1869329: OpenStack: Bootstrap server in the masters AZ Bug 1869329: OpenStack: Place Bootstrap in one of the master AZs Aug 17, 2020
@yussufsh
Provision bootstrap instance in given availability zone similar to ma…
0e71f3a 
…sters. Currently bootstrap is created in default zone.

Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@yussufsh
Copy link
Contributor Author

Our linter is very picky... @yussufsh can you please make the required indentation change?

It is a good thing 👍

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@pierreprinetti
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c5495cc into openshift:master Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@yussufsh: All pull requests linked via external trackers have merged: openshift/installer#4056. Bugzilla bug 1869329 has been moved to the MODIFIED state.

In response to this:

Bug 1869329: OpenStack: Place Bootstrap in one of the master AZs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees

@mandre mandre

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yussufsh @pierreprinetti @openshift-ci-robot @mandre @openshift-bot @openshift-merge-robot