bug 1863026: docs/user/azure: remove newlines from base64 encoding in UPI install doc #4090
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@jhixson74: This pull request references Bugzilla bug 1863026, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -344,7 +344,7 @@ Create the deployment using the `az` client: | |||
|
|
|||
| ```sh | |||
| export BOOTSTRAP_URL=`az storage blob url --account-name ${CLUSTER_NAME}sa --account-key $ACCOUNT_KEY -c "files" -n "bootstrap.ign" -o tsv` | |||
| export BOOTSTRAP_IGNITION=`jq -rcnM --arg v "3.1.0" --arg url $BOOTSTRAP_URL '{ignition:{version:$v,config:{replace:{source:$url}}}}' | base64 -w0` | |||
| export BOOTSTRAP_IGNITION=`jq -rcnM --arg v "3.1.0" --arg url $BOOTSTRAP_URL '{ignition:{version:$v,config:{replace:{source:$url}}}}' | base64 | tr -d '\n'` | |||
There was a problem hiding this comment.
if we look at the docs for base64 https://linux.die.net/man/1/base64
-w, --wrap=COLS
Wrap encoded lines after COLS character (default 76). Use 0 to disable line wrapping.
-w0 already does what we need, we should just use that right? instead of another utility to remove newlines.
There was a problem hiding this comment.
This is a Linux only feature, it doesn't work on Mac OS or BSD. I know we have at least a few Mac OS users. What is wrong with keeping this platform neutral ?
There was a problem hiding this comment.
That makes sense. I think in that case your solution works better.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jhixson74: All pull requests linked via external trackers have merged: Bugzilla bug 1863026 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update Azure UPI documentation to base64 encode without newlines.