Bug 1877854: OpenStack: Support multiple subnets #4093
Conversation
adduarte
commented
Aug 26, 2020
adduarte
commented
- Flag primary cluster subnet.
- Attaches bootstrap floating ip to correct subnet.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest |
| @@ -38,5 +38,6 @@ | |||
| - name: 'Create the bootstrap floating IP' | |||
| os_floating_ip: | |||
| state: present | |||
| nat_destination: "{{ os_network }}" | |||
There was a problem hiding this comment.
because the server might have multiple nics, "nat_destination" forces the floating ip to attach to the os_network
|
/retitle [WIP] Bug 1866874: OpenStack: Support multiple subnets |
openshift-ci-robot
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/bugzilla-refresh |
adduarte
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/bugzilla-refresh |
|
/bugzilla refresh |
|
@mandre: Bugzilla bug 1866874 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@pierreprinetti: Bugzilla bug 1866874 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1877854: OpenStack: Support multiple subnets |
openshift-ci-robot
changed the title
|
@adduarte: This pull request references Bugzilla bug 1877854, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-low
adduarte
force-pushed
the
multi_subnet
branch
from
480d2cc
to
d18c5f9
Compare
adduarte
force-pushed
the
multi_subnet
branch
from
d18c5f9
to
7ada29b
Compare
adduarte
force-pushed
the
multi_subnet
branch
from
7ada29b
to
cdb8d19
Compare
- Flag primary cluster subnet. - Attaches bootstrap floating ip to correct subnet.
adduarte
force-pushed
the
multi_subnet
branch
from
cdb8d19
to
6d8d815
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
UPI job was able to deploy the cluster so I feel relatively confident merging this. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@adduarte: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@adduarte: All pull requests linked via external trackers have merged: Bugzilla bug 1877854 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
