hack/update-rhcos-bootimage: update usage example #4097
Conversation
|
/assign @abhinavdahiya |
|
/approve |
|
/retest |
|
Hmm.. this doesn't make a lot of sense to me to keep this in the installer, the URLs are something ART and RHCOS team controls and putting this translation in the installer script seems incorrect. Converting the RHCOS build urls to publicly accessible ones should be done before we try and update the installer. |
|
@abhinavdahiya It's meant as a convenience for the person running the script. But I can drop the second commit if you'd prefer; we should still keep the first one. |
The example URL is missing the /art/ path prefix, which makes it unclear how to derive the external URL from the meta.json link in the ART build browser.
bgilbert
changed the title
|
Rebased, and dropped the second commit per #4097 (comment). |
|
/retest |
|
@bgilbert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
abhinavdahiya
added
bugzilla/valid-bug
Automatically convert RHT-internal
meta.jsonURL (from the RHCOS ART build browser) to the external openshift.org URL, so the caller doesn't have to do it manually.cc @cgwalters