Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer/pkg/quota/gcp/limits.go: fix minor typo in comment #4160

Merged
merged 2 commits into from Oct 5, 2020
Merged

installer/pkg/quota/gcp/limits.go: fix minor typo in comment #4160

merged 2 commits into from Oct 5, 2020

Conversation

RiRa12621
Copy link
Contributor

No description provided.

@RiRa12621
Copy link
Contributor Author

/assign @crawford

@RiRa12621
Copy link
Contributor Author

/retest

2 similar comments
@RiRa12621
Copy link
Contributor Author

/retest

@RiRa12621
Copy link
Contributor Author

/retest

mtnbikenc
mtnbikenc reviewed Sep 16, 2020
View reviewed changes
pkg/quota/gcp/limits.go Outdated Show resolved Hide resolved
@mtnbikenc
Update pkg/quota/gcp/limits.go
e65b940 
Co-authored-by: Russell Teague <rteague@redhat.com>
@RiRa12621
Copy link
Contributor Author

/retest
why is my change to the comments breaking all tests

@openshift-ci-robot
Copy link
Contributor

@RiRa12621: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack e65b940 link /test e2e-openstack
ci/prow/e2e-metal-ipi e65b940 link /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 e65b940 link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc e65b940 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@jstuever jstuever removed their assignment Sep 21, 2020
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4e6c18c into openshift:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc left review comments

@jstuever jstuever jstuever approved these changes

Assignees

@crawford crawford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@RiRa12621 @openshift-ci-robot @jstuever @abhinavdahiya @mtnbikenc @crawford @openshift-merge-robot