Bug 1878108: asset/quota/gcp: use GCP api to find CPU count for constraint and guess only on failure #4163
Conversation
…ss only on failure Previously we were using the machine type name to figure out the CPU count and metric name. But it seems like using the GCP API will be more future proof compared to string matching. So now the constraint calculator will fetch the CPU count from GCP api and only on failure guess the count using string matching. Fallback to the string matching allows us to guess the CPU count when API access to not available or other failures. The guess always drops the count to 0 when it cannot guess with high confidence. Also adds unit tests for the machine type -> guess cpu function and use GCP api and fallback to guess function.
openshift-ci-robot
added
bugzilla/severity-urgent
|
@abhinavdahiya: This pull request references Bugzilla bug 1878108, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp |
|
/cc @NautiluX @RiRa12621 |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, mtnbikenc, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@abhinavdahiya: All pull requests linked via external trackers have merged: Bugzilla bug 1878108 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously we were using the machine type name to figure out the CPU count and metric name. But it seems like using the GCP API
will be more future proof compared to string matching.
So now the constraint calculator will fetch the CPU count from GCP api and only on failure guess the count using string matching.
Fallback to the string matching allows us to guess the CPU count when API access to not available or other failures. The guess always drops the count to 0 when it cannot guess with high confidence.
Also adds unit tests for the machine type -> guess cpu function and use GCP api and fallback to guess function.
/cc @jstuever @gregsheremeta
/assign @jstuever