Bug 1877486: proxy: allow * for noProxy #4172
Conversation
"*" is considered to be a valid value for noProxy according to [1] So the installer allows setting "*" for noProxy and matches the network operator for configuring .status.noProxy when such a value is set based on [2] i.e. as-is set the noProxy to "*" without adding any default noProxy values. [1]: https://docs.openshift.com/container-platform/4.5/installing/installing_bare_metal/installing-restricted-networks-bare-metal.html#installation-configure-proxy_installing-restricted-networks-bare-metal [2]: https://github.com/openshift/cluster-network-operator/blob/210e2dea2a60c18c277a7249d04085472a6b9a8c/pkg/controller/proxyconfig/status.go#L21-L28
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@abhinavdahiya: This pull request references Bugzilla bug 1877486, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
/approve /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, mtnbikenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: All pull requests linked via external trackers have merged: Bugzilla bug 1877486 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
"" is considered to be a valid value for noProxy according to 1
So the installer allows setting "" for noProxy and matches the network operator for configuring .status.noProxy when such a value is set based on 2 i.e. as-is set the noProxy to "*"
without adding any default noProxy values.