Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1879891: Fix cluster destroy when fip less installation happened #4191

Merged
merged 1 commit into from Sep 18, 2020
Merged

Bug 1879891: Fix cluster destroy when fip less installation happened #4191

merged 1 commit into from Sep 18, 2020

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Sep 17, 2020 •
edited

In case the machines Subnet is not connected to a Router
there is not a need to clean-up the interfaces from the
custom Router as no additional interfaces would have
been created on it. Also, when using Kuryr if a Service
of LoadBalancer type was created, a floating ip would get
created for the load balancer and the removal of the service
subnet from the router would be blocked.

This commit fixes both issues by ignoring the custom Router
clean-up when no Router is found and moving the custom
Router clean-up to after the load balancers removal.

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1879891, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879891: Fix cluster destroy when fip less installation happened

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 17, 2020
@MaysaMacedo
Copy link
Contributor Author

/hold
I need to get feedback from the reporter of the Bugzilla before proceeding with this PR

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@MaysaMacedo
Fix cluster destroy on a FIP less installation
81c1a0f 
In case the machines Subnet is not connected to a Router
there is not a need to clean-up the interfaces from the
custom Router as no additional interfaces would have
been created on it. Also, when using Kuryr if a Service
of LoadBalancer type was created, a floating ip would get
created for the load balancer and the removal of the service
subnet from the router would be blocked.

This commit fixes both issues by ignoring the custom Router
clean-up when no Router is found and moving the custom
Router clean-up to after the load balancers removal.
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1879891, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879891: Fix cluster destroy when fip less installation happened

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@MaysaMacedo
Copy link
Contributor Author

/assign @mandre
/cc @luis5tb

@luis5tb
Copy link
Contributor

luis5tb commented Sep 18, 2020

looks good to me

@MaysaMacedo
Copy link
Contributor Author

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Sep 18, 2020

/lgtm
/hold until e2e-openstack is passing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@mandre
Copy link
Member

mandre commented Sep 18, 2020

/approve

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2020
@MaysaMacedo
Copy link
Contributor Author

/hold cancel

e2e-openstack is green.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@mandre
Copy link
Member

mandre commented Sep 18, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Sep 18, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 81c1a0f link /test e2e-ovirt
ci/prow/e2e-aws-fips 81c1a0f link /test e2e-aws-fips
ci/prow/e2e-libvirt 81c1a0f link /test e2e-libvirt
ci/prow/e2e-crc 81c1a0f link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6ea9f31 into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: All pull requests linked via external trackers have merged:

Bugzilla bug 1879891 has been moved to the MODIFIED state.

In response to this:

Bug 1879891: Fix cluster destroy when fip less installation happened

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo MaysaMacedo mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

@luis5tb luis5tb Awaiting requested review from luis5tb

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaysaMacedo @openshift-ci-robot @luis5tb @mandre @openshift-merge-robot