Bug 1880132: destroy/gcp: correct extract service account email from IAM policy binding member #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abhinavdahiya: GitHub didn't allow me to request PR reviews from the following users: abhinavdahiya. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
abhinavdahiya
force-pushed
the
test_gcp_leak
branch
from
d10ae3a
to
e815c96
Compare
…nding member openshift@e580a61 used to prefix match member with service account email which allowed trailing `?uid` But in openshift@5a460d2#diff-10deb10b2bb7d004df02aa4a5e123e3eR43 we moved to exact matching the member with service account email. This skips the deleted serviceaccount as they have a `?uid={}` suffix as described in https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding , see `members[]` So now we extract the service account email more accurately for exact string match.
abhinavdahiya
force-pushed
the
test_gcp_leak
branch
from
e815c96
to
f9fd06f
Compare
abhinavdahiya
changed the title
abhinavdahiya
changed the title
|
/test e2e-gcp |
abhinavdahiya
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@abhinavdahiya: This pull request references Bugzilla bug 1880132, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/assign @jstuever |
|
/cherry-pick release-4.5 |
|
@abhinavdahiya: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp |
|
testing locally I can see the service accounts are now getting cleaned up correctly. It now picks all the member bindings. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@abhinavdahiya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The gcp job finished install and had some e2e failure. The aws error seems like not related to this PR since it changes only gcp destroy code. So going to merge to relieve ci. Merging |
|
@abhinavdahiya: All pull requests linked via external trackers have merged: Bugzilla bug 1880132 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhinavdahiya: new pull request created: #4195 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/test e2e-gcp
/cc @abhinavdahiya