Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member #4197

Merged
merged 1 commit into from Sep 18, 2020
Merged

[release-4.4] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member #4197

merged 1 commit into from Sep 18, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4195

/assign jstuever

@abhinavdahiya
destroy/gcp: correct extract service account email from IAM policy bi…
d81441e 
…nding member

openshift@e580a61 used to prefix match member with service account email which allowed trailing `?uid`
But in openshift@5a460d2#diff-10deb10b2bb7d004df02aa4a5e123e3eR43 we moved to exact matching the member with service account email.

This skips the deleted serviceaccount as they have a `?uid={}` suffix as described in https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding , see `members[]`

So now we extract the service account email more accurately for exact string match.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 17, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1880134 has been cloned as Bugzilla bug 1880202. Retitling PR to link against new bug.
/retitle [release-4.4] [release-4.5] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member

In response to this:

[release-4.4] [release-4.5] Bug 1880134: destroy/gcp: correct extract service account email from IAM policy binding member

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] [release-4.5] Bug 1880134: destroy/gcp: correct extract service account email from IAM policy binding member [release-4.4] [release-4.5] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member Sep 17, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1880202, which is invalid:

  • expected dependent Bugzilla bug 1880134 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] [release-4.5] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever
Copy link
Contributor

/retitle [release-4.4] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] [release-4.5] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member [release-4.4] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member Sep 17, 2020
@jstuever
Copy link
Contributor

/test e2e-gcp

@jstuever
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@wking wking mentioned this pull request Sep 17, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp d81441e link /test e2e-gcp
ci/prow/e2e-ovirt d81441e link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1880202, which is invalid:

  • expected dependent Bugzilla bug 1880134 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markmc
Copy link
Contributor

markmc commented Sep 18, 2020

As per @sdodson in the upstream PR:

I'm overriding the bugzilla flag and setting cherry-pick-approved because this only affects cluster
destruction and will have an immediate impact on CI availability.

@markmc markmc added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8547b64 into openshift:release-4.4 Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1880202 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1880202: destroy/gcp: correct extract service account email from IAM policy binding member

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @jstuever @openshift-bot @markmc @openshift-merge-robot @abhinavdahiya