Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1848945: OpenStack - Documentation for adding worker nodes using ansible #4205

Merged
merged 1 commit into from Nov 19, 2020
Merged

Bug 1848945: OpenStack - Documentation for adding worker nodes using ansible #4205

merged 1 commit into from Nov 19, 2020

Conversation

adduarte
Copy link

When adding worker nodes via ansible playbooks
there re certain settings that need to be configure on the node.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

@adduarte: This pull request references Bugzilla bug 1848945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1848945: OpenStack - Adding worker nodes using ansible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adduarte adduarte force-pushed the bz_1848945 branch 2 times, most recently from e5c6068 to 869577d Compare September 24, 2020 14:43
@adduarte adduarte changed the title [WIP] Bug 1848945: OpenStack - Adding worker nodes using ansible Bug 1848945: OpenStack - Adding worker nodes using ansible Sep 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2020
@adduarte adduarte changed the title Bug 1848945: OpenStack - Adding worker nodes using ansible Bug 1848945: OpenStack - Documentation for adding worker nodes using ansible Sep 24, 2020
adduarte
adduarte commented Sep 24, 2020
View reviewed changes
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
@adduarte
Copy link
Author

We need to add details about dns resolution of the API endpoints before adding a new host.

adduarte
adduarte commented Oct 1, 2020
View reviewed changes
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
pierreprinetti
pierreprinetti reviewed Oct 2, 2020
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments about Markdown formatting. For reference, you can check the rendered document.

Have you considered adding this documentation as a playbook in upi/openstack? Maybe even as two playbooks given that "separate network" needs special handling. Just a suggestion.

docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
mandre
mandre reviewed Oct 2, 2020
View reviewed changes
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
docs/user/openstack/add_worker_nodes_by_hand.md Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Contributor

@adduarte: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 4d62c63 link /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi 4d62c63 link /test e2e-metal-ipi
ci/prow/e2e-crc 4d62c63 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adduarte adduarte requested a review from mandre November 17, 2020 21:20
@openshift-merge-robot
Copy link
Contributor

@adduarte: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc e894d59 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 38c1d53 into openshift:master Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

@adduarte: All pull requests linked via external trackers have merged:

Bugzilla bug 1848945 has been moved to the MODIFIED state.

In response to this:

Bug 1848945: OpenStack - Documentation for adding worker nodes using ansible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bz_1848945 branch December 9, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@iamemilio iamemilio Awaiting requested review from iamemilio

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adduarte @openshift-ci-robot @openshift-merge-robot @mandre @pierreprinetti @iamemilio